feat: (WIP) Support arbitrary analytics endpoint URLs #285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @tiagoapolo, it seems we could remove the fetch polyfill if we start to document that we only support node >=18. I think this is ok considering LTS. If this is correct, I think this leads to the future possibility of deprecating isomporphic since we aren't polyfiling fetch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to Flagsmith/flagsmith-nodejs-client#168
Tests not passing because
Requestis not available when usingunfetch, or possibly some other issue with the Jest or TypeScript configuration. I would strongly prefer removingfetchpolyfills and sticking to nativefetchfor browsers and Node if feasible.