Skip to content

Conversation

@polatolu
Copy link

@polatolu polatolu commented Oct 8, 2025

Description

Added a User-Agent HTTP header to network calls. Uses the package's version at runtime, if it is not available sends it as "unknown"

Also added a PR template, once this merged new PRs will come with this PR template.

Regression Test Recommendations

  • Test that User-Agent header is present in all HTTP requests with correct format: flagsmith-swift-ios-sdk/
  • Test fallback to "unknown" when version is not discoverable at runtime
  • Validate User-Agent appears in both REST API calls and SSE connections

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore

Unit Test Results

Screenshot 2025-10-08 at 20 17 07

@polatolu polatolu requested a review from a team as a code owner October 8, 2025 09:15
@polatolu polatolu requested review from kyle-ssg and removed request for a team October 8, 2025 09:15

## Estimated time to fix the ticket(s) or epic(s) refernced by the PR in days

- #FD343 - 2 days
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please remove this estimate line, my fault, sorry

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants