Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: lock to django 4 #3

Merged
merged 2 commits into from
Sep 5, 2024
Merged

deps: lock to django 4 #3

merged 2 commits into from
Sep 5, 2024

Conversation

matthewelwell
Copy link
Contributor

No description provided.

@matthewelwell matthewelwell requested review from a team and zachaysan and removed request for a team September 5, 2024 14:12
Copy link
Contributor

@zachaysan zachaysan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks odd that the django upgrade is pinned to <5.0.0 but I assume thats a safe way of doing it.

@matthewelwell
Copy link
Contributor Author

It looks odd that the django upgrade is pinned to <5.0.0 but I assume thats a safe way of doing it.

Yeah, I want to keep the restrictions as loose as possible here. Really there's nothing stopping us for keeping it as "*" but I had to upgrade from 5.0.8 -> 5.1.1 because of a security vulnerability and it felt odd doing so when I know that it won't actually be running on 5.x.

@matthewelwell matthewelwell merged commit ce530a6 into main Sep 5, 2024
1 check passed
@matthewelwell matthewelwell deleted the deps/bump-django branch September 5, 2024 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants