[Operator] Add sort op #322
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tongxin
reviewed
Dec 2, 2024
src/flag_gems/ops/sort.py
Outdated
Comment on lines
51
to
52
| elif sort_elem_cnt > 512: | ||
| return torch.sort(inp, stable=False, dim=dim, descending=descending) |
There was a problem hiding this comment.
Shall we leave TODO note notifying us on future planning?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Category
Operator
Type of Change
New Feature
Description
Add sort op.
This PR is modified according to the PR #222 submitted by MARD1NO (ZZK) from SiliconFlow.
Issue
Progress
Performance