fix(gbak): Stop blob reading when restore task receives stop signal #8529
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prevents SIGFAULT by immediately terminating blob processing when a stop signal is received during restore operations.
|
Hmm... looks like the whole fix for #8444 should be backported into v5, not just this part. |
Agreed. Certainly backport it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevents SIGFAULT by immediately stopping blob processing when a stop signal is received during restore operations.
This can happen when restoring in multiple threads. The problem in
RestoreRelationTask::checkSpacewhere we don't check the result ofgetCleanBuffer()fornullptrand it causes corruption inIOBufferlinked list. This can lead to a sigfault inRestoreRelationTask::read_blob()where thecheckSpace()function is called multiple times.This was already fixed in v6 (commit), but I don't think the main purpose of that commit was to fix specifically this problem.