Skip to content

fix(firestore): make includeMetadataChanges a configurable option #99

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
blackholegalaxy wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix(firestore): make includeMetadataChanges a configurable option #99

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d6fe20a
fix(firestore): make includeMetadataChanges a configurable option
blackholegalaxy Mar 24, 2024
b08330e
fix(firestore): change object notation lint
blackholegalaxy Mar 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions firestore/collection/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -188,10 +188,11 @@ const filterEmptyUnlessFirst = <T = unknown>(): UnaryFunction<
export function collectionChanges<T=DocumentData>(
query: Query<T>,
options: {
events?: DocumentChangeType[]
}={},
events?: DocumentChangeType[],
includeMetadataChanges: boolean
}={includeMetadataChanges: true},
): Observable<DocumentChange<T>[]> {
return fromRef(query, {includeMetadataChanges: true}).pipe(
return fromRef(query, {includeMetadataChanges: options.includeMetadataChanges}).pipe(
windowwise(),
map(([priorSnapshot, currentSnapshot]) => {
const docChanges = currentSnapshot.docChanges();
Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "rxfire",
"version": "6.0.6",
"version": "6.0.7",
"private": true,
"description": "Firebase JavaScript library RxJS",
"author": "Firebase <[email protected]> (https://firebase.google.com/)",
Expand Down