Skip to content

Conversation

@KingDarBoja
Copy link

@KingDarBoja KingDarBoja commented Oct 5, 2025

Changes

  • Switch ESLint to Flat Config.
  • Peer dependencies updated to support only firebase v12 and above due to the renaming of firebase/vertexai to firebase/ai.
  • Type fixes around a few definitions.
  • Reconfigure rollup plugins with latest versions.

This should fix #122 and probably #93 and #94 as I managed to provide correct typing fixes to that.

I started doing this after seeing issues like angular/angularfire#3666 due to firebase v12 renaming the vertexai thingy.

- Switch ESLint to Flat Config.
- Peer dependencies updated to support only firebase v12 and above due to the renaming of firebase/vertexai to firebase/ai.
@gemini-code-assist
Copy link

Summary of Changes

Hello @KingDarBoja, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on a significant dependency upgrade, primarily moving to Firebase version 12, which required adapting to API changes like the firebase/ai renaming. It also modernizes the project's development tooling by migrating to the new ESLint Flat Config system and updating build-related Rollup plugins. These updates ensure the project remains current, compatible with the latest Firebase ecosystem, and benefits from improved linting and build processes.

Highlights

  • Firebase v12 Upgrade: The project's peer dependency on Firebase has been updated to version 12, necessitating changes due to the renaming of firebase/vertexai to firebase/ai and ensuring compatibility with other packages like @angular/fire v20.
  • ESLint Flat Config Migration: The linting setup has been modernized by switching to ESLint Flat Config (ESLint v9), which involved adding a new eslint.config.mjs file and updating linting scripts.
  • New AI Module: A new ai module has been introduced, providing an observable wrapper for firebase/ai's startAudioConversation function, along with its own package.json and documentation.
  • Rollup Plugin Updates: Several Rollup plugins used for building have been updated, including the addition of @rollup/plugin-json, though a specific issue with @rollup/plugin-typescript v12.x.x regarding declaration files was noted and addressed by reverting to v11.
  • Type Definition Enhancements: Various type definitions across auth, database, firestore, and firestore/lite modules have been refined and corrected for improved type safety and clarity.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request brings several important updates, including upgrading to Firebase v12, switching to ESLint's Flat Config, and adding support for firebase/ai. The dependency updates and configuration changes are well-executed. I've found a few areas for improvement, mainly around consistent use of modern RxJS APIs and improving type safety in a couple of spots. There's also a minor typo in a test file. Overall, this is a solid update that modernizes the project's tooling and dependencies.

@KingDarBoja
Copy link
Author

@jamesdaniels any updates on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add support for Firestore v12

1 participant