Skip to content

Revert "Block builds on vulnerable nextjs versions" #451

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
annajowang wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Revert "Block builds on vulnerable nextjs versions" #451

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9480176
Revert "Block builds on vulnerable nextjs versions (#447)"
annajowang Dec 4, 2025
dd9be7f
update package version
annajowang Dec 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 2 additions & 3 deletions packages/@apphosting/adapter-nextjs/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@apphosting/adapter-nextjs",
"version": "14.0.21",
"version": "14.0.22",
"main": "dist/index.js",
"description": "Experimental addon to the Firebase CLI to add web framework support",
"repository": {
Expand Down Expand Up @@ -45,8 +45,7 @@
"dependencies": {
"@apphosting/common": "*",
"fs-extra": "^11.1.1",
"yaml": "^2.3.4",
"semver": "^7.7.3"
"yaml": "^2.3.4"
},
"peerDependencies": {
"next": "*"
Expand Down
2 changes: 0 additions & 2 deletions packages/@apphosting/adapter-nextjs/src/bin/build.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@ import {
validateOutputDirectory,
getAdapterMetadata,
exists,
checkNextJSVersion,
} from "../utils.js";
import { join } from "path";
import { getBuildOptions, runBuild } from "@apphosting/common";
Expand All @@ -25,7 +24,6 @@ process.env.NEXT_PRIVATE_STANDALONE = "true";
// Opt-out sending telemetry to Vercel
process.env.NEXT_TELEMETRY_DISABLED = "1";

checkNextJSVersion(process.env.FRAMEWORK_VERSION);
const nextConfig = await loadConfig(root, opts.projectDirectory);

/**
Expand Down
54 changes: 0 additions & 54 deletions packages/@apphosting/adapter-nextjs/src/utils.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,60 +6,6 @@ import path from "path";
import os from "os";
import { RoutesManifest, MiddlewareManifest } from "../src/interfaces.js";

describe("block vulnerable nextjs versions", () => {
it("check for vulnerable versions", async () => {
const { checkNextJSVersion } = await importUtils;

assert.throws(() => {
checkNextJSVersion("15.0.0");
});

assert.doesNotThrow(() => {
checkNextJSVersion(undefined);
});

assert.doesNotThrow(() => {
checkNextJSVersion("15.0.5");
});

assert.throws(() => {
checkNextJSVersion("15.4.7");
});

assert.doesNotThrow(() => {
checkNextJSVersion("15.4.8");
});

assert.doesNotThrow(() => {
checkNextJSVersion("14.0.12");
});

assert.throws(() => {
checkNextJSVersion("14.3.0-canary.77");
});

assert.throws(() => {
checkNextJSVersion("14.3.0-canary.78");
});

assert.doesNotThrow(() => {
checkNextJSVersion("14.3.0-canary.76");
});

assert.throws(() => {
checkNextJSVersion("15.0.0-canary.2");
});

assert.throws(() => {
checkNextJSVersion("16.0.6");
});

assert.doesNotThrow(() => {
checkNextJSVersion("16.0.7");
});
});
});

describe("manifest utils", () => {
let tmpDir: string;
let distDir: string;
Expand Down
16 changes: 0 additions & 16 deletions packages/@apphosting/adapter-nextjs/src/utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
import fsExtra from "fs-extra";
import semVer from "semver";
import { createRequire } from "node:module";
import { join, dirname, relative, normalize } from "path";
import { fileURLToPath } from "url";
Expand All @@ -18,21 +17,6 @@ import { OutputBundleConfig, updateOrCreateGitignore } from "@apphosting/common"
// fs-extra is CJS, readJson can't be imported using shorthand
export const { copy, exists, writeFile, readJson, readdir, readFileSync, existsSync, ensureDir } =
fsExtra;
export const { satisfies } = semVer;

const SAFE_NEXTJS_VERSIONS =
">=16.1.0 || ~16.0.7 || ~v15.5.7 || ~v15.4.8 || ~v15.3.6 || ~v15.2.6 || ~v15.1.9 || ~v15.0.5 || <14.3.0-canary.77";

export function checkNextJSVersion(version: string | undefined) {
if (!version) {
return;
}
if (!satisfies(version, SAFE_NEXTJS_VERSIONS)) {
throw new Error(
`CVE-2025-55182: Vulnerable Next version ${version} detected. Deployment blocked. Update your app's dependencies to a patched Next.js version and redeploy: https://nextjs.org/blog/CVE-2025-66478#fixed-versions`,
);
}
}

// Loads the user's next.config.js file.
export async function loadConfig(root: string, projectRoot: string): Promise<NextConfigComplete> {
Expand Down