Set App Hosting overrides for NextJS apps without a Next Config #323
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mathu97
requested review from
Yuangwang,
sjjj986,
jamesdaniels,
annajowang,
blidd-google and
taeold
as code owners
annajowang
approved these changes
Apr 8, 2025
| if (!userNextConfigExists) { | ||
| console.log(`No Next config file found, creating one with Firebase App Hosting overrides`); | ||
| try { | ||
| await writeFile(join(projectRoot, DEFAULT_NEXT_CONFIG_FILE), defaultNextConfigForFAH()); |
There was a problem hiding this comment.
Does nextConfigFileName include the default filename? Then we can drop nextConfigFileName in favor.
jamesdaniels
approved these changes
Apr 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we're skipping adding FAH overrides for Next projects that don't have a Next Config file.