Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ipv6 #40

Merged
merged 3 commits into from
Oct 21, 2024
Merged

Ipv6 #40

merged 3 commits into from
Oct 21, 2024

Conversation

TheTeaCat
Copy link
Member

Describe your changes

Updates the middleware to handle more of the possible formats of the http.Request RemoteAddr field.

Issue ticket number and link

https://firetail-io.atlassian.net/browse/FIRE-2763

Checklist before requesting a review

  • I have resolved any merge conflicts
  • I have run tests locally and they pass
  • I have linted and auto-formatted the code
  • If there is new or changed functionality, I have added/updated the tests
  • If there is new or changed functionality, I have added/updated the documentation

@TheTeaCat TheTeaCat self-assigned this Oct 21, 2024
Copy link

codecov bot commented Oct 21, 2024

Codecov Report

Attention: Patch coverage is 25.00000% with 6 lines in your changes missing coverage. Please review.

Project coverage is 83.21%. Comparing base (20125ed) to head (7aa4a72).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
logging/default_batch_callback.go 0.00% 3 Missing ⚠️
middlewares/http/middleware.go 40.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #40      +/-   ##
==========================================
- Coverage   84.08%   83.21%   -0.88%     
==========================================
  Files           8        8              
  Lines         553      560       +7     
==========================================
+ Hits          465      466       +1     
- Misses         75       80       +5     
- Partials       13       14       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rileyfiretail rileyfiretail merged commit efde6ca into main Oct 21, 2024
1 of 3 checks passed
@rileyfiretail rileyfiretail deleted the ipv6 branch October 21, 2024 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants