Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v0.2.0 #38

Merged
merged 6 commits into from
Mar 1, 2024
Merged

v0.2.0 #38

merged 6 commits into from
Mar 1, 2024

Conversation

TheTeaCat
Copy link
Member

@TheTeaCat TheTeaCat commented Mar 1, 2024

New feature: the batching logic is now customisable via the Options struct's MaxLogAge and MaxBatchSize.

Patch: the custom batch callback was not being set properly, resulting in a nil pointer dereference when it was used.

Patch: the Resource field was not populated with any data when no OpenAPI spec is used to validate the logs.

@TheTeaCat TheTeaCat requested a review from timoruppell March 1, 2024 15:36
@TheTeaCat TheTeaCat self-assigned this Mar 1, 2024
Copy link

codecov bot commented Mar 1, 2024

Codecov Report

Attention: Patch coverage is 80.00000% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 84.08%. Comparing base (5160c3f) to head (e49384e).
Report is 1 commits behind head on main.

Files Patch % Lines
middlewares/http/middleware.go 72.72% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #38      +/-   ##
==========================================
- Coverage   84.34%   84.08%   -0.26%     
==========================================
  Files           8        8              
  Lines         543      553      +10     
==========================================
+ Hits          458      465       +7     
- Misses         73       75       +2     
- Partials       12       13       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@TheTeaCat TheTeaCat merged commit 16f588f into main Mar 1, 2024
2 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants