Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing resource in logs, fix custom batch callback & make batches configurable #37

Merged
merged 6 commits into from
Mar 1, 2024

Conversation

TheTeaCat
Copy link
Member

  • Fixes missing resource in logs
  • Fixes custom batch callback not being used when set
  • Makes max batch size and log age configurable

@TheTeaCat TheTeaCat self-assigned this Mar 1, 2024
@TheTeaCat TheTeaCat changed the base branch from main to dev March 1, 2024 15:30
Copy link

codecov bot commented Mar 1, 2024

Codecov Report

Attention: Patch coverage is 80.00000% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 84.08%. Comparing base (5160c3f) to head (481a74d).

Files Patch % Lines
middlewares/http/middleware.go 72.72% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev      #37      +/-   ##
==========================================
- Coverage   84.34%   84.08%   -0.26%     
==========================================
  Files           8        8              
  Lines         543      553      +10     
==========================================
+ Hits          458      465       +7     
- Misses         73       75       +2     
- Partials       12       13       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@TheTeaCat TheTeaCat merged commit e49384e into dev Mar 1, 2024
1 of 3 checks passed
@TheTeaCat TheTeaCat deleted the fix-missing-resource-2 branch March 1, 2024 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants