Skip to content

Commit

Permalink
Remove useless kubebuilder comment in webhook (chaos-mesh#3816)
Browse files Browse the repository at this point in the history
* remove useless kubebuilder comment in webhook

Signed-off-by: Ningxuan Wang <[email protected]>

* update CHANGELOG.md

Signed-off-by: Ningxuan Wang <[email protected]>

Signed-off-by: Ningxuan Wang <[email protected]>
  • Loading branch information
FingerLeader authored Nov 24, 2022
1 parent f7cb8eb commit ea99efa
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 4 deletions.
2 changes: 2 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,8 @@ For more information and how-to, see [RFC: Keep A Changelog](https://github.com/

- Remove not needed file crd-v1beta1.yaml [#3807](https://github.com/chaos-mesh/chaos-mesh/pull/3807)

- Remove useless kubebuilder comment in webhook [#3816](https://github.com/chaos-mesh/chaos-mesh/pull/3816)

### Fixed

- Remove the explicit use of pingcap/log [#3674](https://github.com/chaos-mesh/chaos-mesh/pull/3674)
Expand Down
4 changes: 0 additions & 4 deletions api/v1alpha1/schedule_webhook.go
Original file line number Diff line number Diff line change
Expand Up @@ -28,8 +28,6 @@ import (
// log is for logging in this package.
var schedulelog = logf.Log.WithName("schedule-resource")

// +kubebuilder:webhook:path=/mutate-chaos-mesh-org-v1alpha1-schedule,mutating=true,failurePolicy=fail,groups=chaos-mesh.org,resources=schedule,verbs=create;update,versions=v1alpha1,name=mschedule.kb.io

var _ webhook.Defaulter = &Schedule{}

// Default implements webhook.Defaulter so a webhook will be registered for the type
Expand All @@ -44,8 +42,6 @@ func (in *ConcurrencyPolicy) Default() {
}
}

// +kubebuilder:webhook:verbs=create;update,path=/validate-chaos-mesh-org-v1alpha1-schedule,mutating=false,failurePolicy=fail,groups=chaos-mesh.org,resources=schedule,versions=v1alpha1,name=vschedule.kb.io

var _ webhook.Validator = &Schedule{}

// ValidateCreate implements webhook.Validator so a webhook will be registered for the type
Expand Down

0 comments on commit ea99efa

Please sign in to comment.