Skip to content

Conversation

@ikseong00
Copy link
Collaborator

@ikseong00 ikseong00 commented Dec 23, 2025

Related issue ๐Ÿ› 

Work Description ๐Ÿ“

  • ์ž‘์—… ๋‚ด์šฉ

Screenshot ๐Ÿ“ธ

Uncompleted Tasks ๐Ÿ˜…

  • Task1

To Reviewers ๐Ÿ“ข

Summary by CodeRabbit

๋ฆด๋ฆฌ์Šค ๋…ธํŠธ

  • New Features

    • ๋กœ๊ทธ์ธ ํ™”๋ฉด์œผ๋กœ ์ด๋™ํ•˜๋Š” ๊ธฐ๋Šฅ ์ถ”๊ฐ€
    • ๊ฒŒ์ŠคํŠธ ๋ฐ ๋“ฑ๋ก๋œ ์‚ฌ์šฉ์ž์— ๋Œ€ํ•œ ์ฐจ๋ณ„ํ™”๋œ UI ์ œ๊ณต
  • Bug Fixes

    • ์ธ์ฆ ์˜ค๋ฅ˜ ๋ฐœ์ƒ ์‹œ ์ž๋™์œผ๋กœ ๋กœ๊ทธ์ธ ํ™”๋ฉด์œผ๋กœ ๋ฆฌ๋””๋ ‰์…˜
  • Style

    • ์•ฑ ์ด๋ฆ„์„ ํ•œ๊ตญ์–ด๋กœ ๋ณ€๊ฒฝ ("์ฐพ์•„์œ ")
    • ์ผ๋ถ€ UI ์š”์†Œ ์ˆจ๊น€ ์ฒ˜๋ฆฌ
    • ๋ ˆ์ด์•„์›ƒ ํŒจ๋”ฉ ์กฐ์ •
  • Chores

    • ๋ฒ„์ „ ์—…๊ทธ๋ ˆ์ด๋“œ (1.0.4 โ†’ 1.0.11)

โœ๏ธ Tip: You can customize this high-level summary in your review settings.

- ๊ฒ€์ƒ‰ ์ƒ์„ธ(์‹ค์ข…, ๋ชฉ๊ฒฉ) ํ™”๋ฉด์—์„œ ๋ถ๋งˆํฌ ์•„์ด์ฝ˜์ด ๋ณด์ด์ง€ ์•Š๋˜ ๋ฌธ์ œ๋ฅผ ์ˆ˜์ •ํ•ฉ๋‹ˆ๋‹ค.
- ๋Œ“๊ธ€ ๋ฒ„ํŠผ์„ ์ˆจ๊น€ ์ฒ˜๋ฆฌํ•ฉ๋‹ˆ๋‹ค.
- ์ผ๋ถ€ ์ฝ”๋“œ ์ˆœ์„œ๋ฅผ ์ •๋ฆฌํ•ฉ๋‹ˆ๋‹ค.
- ์ƒ์„ธ ํ™”๋ฉด์—์„œ ๋„ค์ด๋ฒ„ ์ง€๋„ ๋กœ๊ณ  ํด๋ฆญ์„ ๋น„ํ™œ์„ฑํ™”ํ•˜์—ฌ ์™ธ๋ถ€ ์•ฑ์œผ๋กœ ์ด๋™ํ•˜๋Š” ๊ฒƒ์„ ๋ฐฉ์ง€
- ๊ฒŒ์ŠคํŠธ ์œ ์ €์ผ ๊ฒฝ์šฐ ๋‹‰๋„ค์ž„ ์ˆ˜์ •, ๋กœ๊ทธ์•„์›ƒ, ํšŒ์›ํƒˆํ‡ด ๋ฒ„ํŠผ์„ ์ˆจ๊น€
- ๊ฒŒ์ŠคํŠธ ์œ ์ €์ผ ๊ฒฝ์šฐ '๋กœ๊ทธ์ธ ํ™”๋ฉด์œผ๋กœ ์ด๋™' ๋ฒ„ํŠผ์„ ํ‘œ์‹œํ•˜๊ณ , ํด๋ฆญ ์‹œ ๋กœ๊ทธ์ธ ํ™”๋ฉด์œผ๋กœ ์ด๋™ ๊ธฐ๋Šฅ ๊ตฌํ˜„
- API 401 ์—๋Ÿฌ ๋ฐœ์ƒ ์‹œ ๋กœ๊ทธ์ธ ํ™”๋ฉด์œผ๋กœ ์ด๋™ํ•˜๋„๋ก ์ˆ˜์ •
- `AuthInterceptor`์—์„œ 401 ์—๋Ÿฌ ํ…Œ์ŠคํŠธ๋ฅผ ์œ„ํ•ด ์ž„์‹œ๋กœ ํ† ํฐ ์•ž์— "1"์„ ์ถ”๊ฐ€
- ๋‹ค์ด์–ผ๋กœ๊ทธ ์ขŒ์šฐ ํŒจ๋”ฉ ๊ฐ’ ์ˆ˜์ •
- ํ”„๋กœํ•„ ์ด๋ฏธ์ง€ ๋ณ€๊ฒฝ ๋ฒ„ํŠผ์˜ ๋„ˆ๋น„๋ฅผ `match_parent`๋กœ ๋ณ€๊ฒฝ
- versionCode: 8 โ†’ 9
- versionName: 1.0.7 โ†’ 1.0.8
- ์•ฑ ์ด๋ฆ„์„ "FindU"์—์„œ "์ฐพ์•„์œ "๋กœ ๋ณ€๊ฒฝ
- ๋งˆ์ดํŽ˜์ด์ง€์˜ ์„ค์ • ๋ฒ„ํŠผ์„ ๋ณด์ด์ง€ ์•Š๋„๋ก ์ˆ˜์ •
- versionCode: 9 -> 11
- versionName: "1.0.8" -> "1.0.10"
- ์•ฑ ๋ฒ„์ „์„ 1.0.10์—์„œ 1.0.11๋กœ ์—…๋ฐ์ดํŠธ
- versionCode๋ฅผ 11์—์„œ 12๋กœ ์—…๋ฐ์ดํŠธ
@coderabbitai
Copy link

coderabbitai bot commented Dec 23, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

๋ฒ„์ „ ์—…๋ฐ์ดํŠธ์™€ ํ•จ๊ป˜ 401 ์ธ์ฆ ์˜ค๋ฅ˜ ์ฒ˜๋ฆฌ ๋กœ์ง์„ ์ถ”๊ฐ€ํ•˜๊ณ , ๊ฒŒ์ŠคํŠธ ์‚ฌ์šฉ์ž UI ๋ถ„๊ธฐ, ๋งต ๋กœ๊ณ  ํด๋ฆญ ๋น„ํ™œ์„ฑํ™”, ํŠน์ • UI ์š”์†Œ ์ˆจ๊น€ ์ฒ˜๋ฆฌ๋ฅผ ํฌํ•จํ•œ ๋‹ค์–‘ํ•œ UI ๋ฐ ๋„คํŠธ์›Œํฌ ๊ณ„์ธต ๋ณ€๊ฒฝ์‚ฌํ•ญ์ด ๋ฐ˜์˜๋˜์—ˆ์Šต๋‹ˆ๋‹ค.

Changes

Cohort / File(s) ๋ณ€๊ฒฝ ์š”์•ฝ
๋ฒ„์ „ ๋ฐ ์•ฑ ๋ฉ”ํƒ€๋ฐ์ดํ„ฐ
app/build.gradle.kts, app/src/main/res/values/strings.xml
versionCode 5โ†’12, versionName "1.0.4"โ†’"1.0.11" ์—…๋ฐ์ดํŠธ; ์•ฑ ์ด๋ฆ„ "FindU"โ†’"์ฐพ์•„์œ " ๋ณ€๊ฒฝ
๋งค๋‹ˆํŽ˜์ŠคํŠธ ๊ถŒํ•œ
app/src/main/AndroidManifest.xml
๊ด‘๊ณ  ID ๊ถŒํ•œ(com.google.android.gms.permission.AD_ID) ์ถ”๊ฐ€
์ธ์ฆ ๋ฐ ๋„คํŠธ์›Œํฌ ๊ณ„์ธต
app/src/main/java/com/kuit/findu/data/dataremote/util/AuthAuthenticator.kt, Exceptions.kt, app/src/main/java/com/kuit/findu/di/NetworkModule.kt
401 ์‘๋‹ต ๊ฐ์ง€ ์‹œ ํ† ํฐ ์ดˆ๊ธฐํ™” ๋ฐ ๋กœ๊ทธ์ธ ํ™”๋ฉด ๋„ค๋น„๊ฒŒ์ด์…˜์„ ์ˆ˜ํ–‰ํ•˜๋Š” AuthAuthenticator ์ธํ„ฐ์…‰ํ„ฐ ์ถ”๊ฐ€; ์˜์กด์„ฑ ์ฃผ์ž… ์„ค์ •
ํ™ˆ ํ™”๋ฉด UI ์ฒ˜๋ฆฌ
app/src/main/java/com/kuit/findu/presentation/ui/home/HomeFragment.kt, HomeViewModel.kt
401 ์˜ค๋ฅ˜ ๊ฐ์ง€ ์‹œ NavigateToLogin ์ดํŽ™ํŠธ ๋ฐœ์ƒ ๋ฐ ๋กœ๊ทธ์ธ ํ™”๋ฉด ์‹œ์ž‘ ๋กœ์ง ์ถ”๊ฐ€
๋งˆ์ด ํŽ˜์ด์ง€
app/src/main/java/com/kuit/findu/presentation/ui/my/MyFragment.kt, app/src/main/res/layout/fragment_my.xml, app/src/main/res/layout/dialog_my_profile_image.xml
๊ฒŒ์ŠคํŠธ ์‚ฌ์šฉ์ž ๋ถ„๊ธฐ ์ฒ˜๋ฆฌ(๋‹‰๋„ค์ž„ "๊ฒŒ์ŠคํŠธ"์ผ ๋•Œ ํŠน์ • ๋ฒ„ํŠผ ์ˆจ๊น€); ํ”„๋กœํ•„ ์ด๋ฏธ์ง€ ์ปจํ…Œ์ด๋„ˆ ์ˆจ๊น€; ์•Œ๋žŒ UI ๋กœ์ง ๋น„ํ™œ์„ฑํ™”; ๋ ˆ์ด์•„์›ƒ ํŒจ๋”ฉ ์กฐ์ •
๊ฒ€์ƒ‰ ์ƒ์„ธ ๋งต UI
app/src/main/java/com/kuit/findu/presentation/ui/search/detail/SearchDisappearDetailFragment.kt, SearchProtectingDetailFragment.kt, SearchWitnessDetailFragment.kt
NaverMap ๋กœ๊ณ  ํด๋ฆญ ๋น„ํ™œ์„ฑํ™”(isLogoClickEnabled = false)
๊ฒ€์ƒ‰ ์ƒ์„ธ ๋ ˆ์ด์•„์›ƒ
app/src/main/res/layout/fragment_search_detail_disappear.xml, fragment_search_detail_witness.xml
๋ฉ”์‹œ์ง€ ์ „์†ก ๊ธฐ๋Šฅ(ll_send_message) visibility="gone"์œผ๋กœ ์„ค์ •
๊ฒ€์ƒ‰ ๋ฐ ๋กœ๊ทธ์ธ UI
app/src/main/res/layout/fragment_search.xml, app/src/main/java/com/kuit/findu/presentation/ui/login/composeview/LoginScreen.kt
"์‹ ๊ณ ํ•˜๊ธฐ" ๋ฒ„ํŠผ ๋ฐ ๊ด€๋ จ FAB ์ˆจ๊น€; Kakao ๋กœ๊ทธ์ธ ์•„์ด์ฝ˜ ์ œ๊ฑฐ

Sequence Diagram

sequenceDiagram
    participant Client as ํด๋ผ์ด์–ธํŠธ (์•ฑ)
    participant Interceptor as AuthAuthenticator<br/>(์ธํ„ฐ์…‰ํ„ฐ)
    participant TokenDS as TokenLocalDataSource
    participant LoginActivity as LoginActivity
    
    Client->>Interceptor: API ์š”์ฒญ ์†ก์‹ 
    Interceptor->>Interceptor: ์‘๋‹ต ์ˆ˜์‹ 
    
    alt 401 ์‘๋‹ต ๊ฐ์ง€
        Interceptor->>TokenDS: clearToken()
        TokenDS->>TokenDS: ์ €์žฅ๋œ ํ† ํฐ ์‚ญ์ œ
        Interceptor->>LoginActivity: startActivity()<br/>(NEW_TASK | CLEAR_TASK)
        LoginActivity->>LoginActivity: ๋กœ๊ทธ์ธ ํ™”๋ฉด ํ‘œ์‹œ
        rect rgb(200, 220, 240)
            note over Interceptor: ์›๋ณธ ์‘๋‹ต ๋ฐ˜ํ™˜
        end
    else ๋‹ค๋ฅธ ์ƒํƒœ ์ฝ”๋“œ
        rect rgb(240, 240, 240)
            Interceptor->>Client: ์‘๋‹ต ํ†ต๊ณผ
        end
    end
Loading

Estimated code review effort

๐ŸŽฏ 3 (Moderate) | โฑ๏ธ ~20 minutes

Possibly related issues

  • [Fix] ์ถœ์‹œ QA ์‚ฌํ•ญ ๋ฐ˜์˜ย #109: ์ด PR์€ ํ•ด๋‹น ์ด์Šˆ์—์„œ ์š”์ฒญ๋œ ๋ชจ๋“  ์ฝ”๋“œ ๋ ˆ๋ฒจ ์ˆ˜์ •์‚ฌํ•ญ์„ ์ง์ ‘ ๊ตฌํ˜„ํ•ฉ๋‹ˆ๋‹คโ€”๊ฒŒ์ŠคํŠธ ๋งˆ์ดํŽ˜์ด์ง€ ์ฒ˜๋ฆฌ, ์•Œ๋žŒ UI ์ œ๊ฑฐ, Naver ๋งต ๋กœ๊ณ  ํด๋ฆญ ๋น„ํ™œ์„ฑํ™”, ๊ฒ€์ƒ‰ ์ƒ์„ธ ๋ ˆ์ด์•„์›ƒ ์กฐ์ •, ์‹ ๊ณ  ๋ฒ„ํŠผ ์ˆจ๊น€, 401 ์˜ค๋ฅ˜ ์ฒ˜๋ฆฌ ๋“ฑ์ด ํฌํ•จ๋ฉ๋‹ˆ๋‹ค.

Possibly related PRs

  • [Feat] search UIย #80: ๋‘ PR ๋ชจ๋‘ ๊ฒ€์ƒ‰ ์ƒ์„ธ ํ”„๋ž˜๊ทธ๋จผํŠธ์˜ ๋งต ํ†ตํ•ฉ์„ ์ˆ˜์ •ํ•ฉ๋‹ˆ๋‹คโ€”์ด PR์€ NaverMap UI ๋™์ž‘์„ ์กฐ์ •(๋กœ๊ณ  ํด๋ฆญ ๋น„ํ™œ์„ฑํ™”)ํ•˜๊ณ , ํ•ด๋‹น PR์€ MapView ๋ฐ ๋งคํ•‘ ๋กœ์ง์„ ์ถ”๊ฐ€/๊ฐœ์„ ํ•ฉ๋‹ˆ๋‹ค.
  • [Feat] mypage UIย #75: ๋‘ PR ๋ชจ๋‘ MyFragment UI์™€ fragment_my.xml์„ ์ˆ˜์ •ํ•ฉ๋‹ˆ๋‹ค(ํ”„๋กœํ•„/๋กœ๊ทธ์ธ/ํ”„๋กœํ•„ ์ด๋ฏธ์ง€ UI ๋ฐ ๊ด€๋ จ ๋ทฐ ID/๋™์ž‘).

Suggested labels

๐Ÿถ์†Œํฌ

Suggested reviewers

  • t1nm1ksun

Poem

๐Ÿ” 401์ด ์šธ๋ฆฌ๋ฉด, ํ† ํฐ์€ ์‚ฌ๋ผ์ง€๊ณ 
๋กœ๊ทธ์ธ ํ™”๋ฉด์œผ๋กœ ์ถค์„ ์ถ˜๋‹ค ๐ŸŽญ
๋งต ๋กœ๊ณ ๋Š” ์กฐ์šฉํžˆ, ์‹ ๊ณ ๋Š” ์ˆจ์–ด์„œ ๐Ÿ—บ๏ธ
๊ฒŒ์ŠคํŠธ์™€ ์‚ฌ์šฉ์ž, ๋‘˜ ๋‹ค ๋ฐ˜๊ฒจ์ฃผ๋Š”
์ฐพ์•„์œ , ์ด์ œ ๋” ๋งค๋„๋Ÿฌ์›Œ์กŒ๋„ค! โœจ

โœจ Finishing touches
  • ๐Ÿ“ Generate docstrings
๐Ÿงช Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix-qa

๐Ÿ“œ Recent review details

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

๐Ÿ“ฅ Commits

Reviewing files that changed from the base of the PR and between a6c3be5 and f2bff24.

๐Ÿ“’ Files selected for processing (18)
  • app/build.gradle.kts
  • app/src/main/AndroidManifest.xml
  • app/src/main/java/com/kuit/findu/data/dataremote/util/AuthAuthenticator.kt
  • app/src/main/java/com/kuit/findu/data/dataremote/util/Exceptions.kt
  • app/src/main/java/com/kuit/findu/di/NetworkModule.kt
  • app/src/main/java/com/kuit/findu/presentation/ui/home/HomeFragment.kt
  • app/src/main/java/com/kuit/findu/presentation/ui/home/viewmodel/HomeViewModel.kt
  • app/src/main/java/com/kuit/findu/presentation/ui/login/composeview/LoginScreen.kt
  • app/src/main/java/com/kuit/findu/presentation/ui/my/MyFragment.kt
  • app/src/main/java/com/kuit/findu/presentation/ui/search/detail/SearchDisappearDetailFragment.kt
  • app/src/main/java/com/kuit/findu/presentation/ui/search/detail/SearchProtectingDetailFragment.kt
  • app/src/main/java/com/kuit/findu/presentation/ui/search/detail/SearchWitnessDetailFragment.kt
  • app/src/main/res/layout/dialog_my_profile_image.xml
  • app/src/main/res/layout/fragment_my.xml
  • app/src/main/res/layout/fragment_search.xml
  • app/src/main/res/layout/fragment_search_detail_disappear.xml
  • app/src/main/res/layout/fragment_search_detail_witness.xml
  • app/src/main/res/values/strings.xml

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

โค๏ธ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@ikseong00 ikseong00 merged commit 2ecb5b2 into develop Dec 23, 2025
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Fix] ์ถœ์‹œ QA ์‚ฌํ•ญ ๋ฐ˜์˜

2 participants