-
Notifications
You must be signed in to change notification settings - Fork 0
Fix qa #110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- ๊ฒ์ ์์ธ(์ค์ข , ๋ชฉ๊ฒฉ) ํ๋ฉด์์ ๋ถ๋งํฌ ์์ด์ฝ์ด ๋ณด์ด์ง ์๋ ๋ฌธ์ ๋ฅผ ์์ ํฉ๋๋ค. - ๋๊ธ ๋ฒํผ์ ์จ๊น ์ฒ๋ฆฌํฉ๋๋ค. - ์ผ๋ถ ์ฝ๋ ์์๋ฅผ ์ ๋ฆฌํฉ๋๋ค.
- ์์ธ ํ๋ฉด์์ ๋ค์ด๋ฒ ์ง๋ ๋ก๊ณ ํด๋ฆญ์ ๋นํ์ฑํํ์ฌ ์ธ๋ถ ์ฑ์ผ๋ก ์ด๋ํ๋ ๊ฒ์ ๋ฐฉ์ง
- ๊ฒ์คํธ ์ ์ ์ผ ๊ฒฝ์ฐ ๋๋ค์ ์์ , ๋ก๊ทธ์์, ํ์ํํด ๋ฒํผ์ ์จ๊น - ๊ฒ์คํธ ์ ์ ์ผ ๊ฒฝ์ฐ '๋ก๊ทธ์ธ ํ๋ฉด์ผ๋ก ์ด๋' ๋ฒํผ์ ํ์ํ๊ณ , ํด๋ฆญ ์ ๋ก๊ทธ์ธ ํ๋ฉด์ผ๋ก ์ด๋ ๊ธฐ๋ฅ ๊ตฌํ
- API 401 ์๋ฌ ๋ฐ์ ์ ๋ก๊ทธ์ธ ํ๋ฉด์ผ๋ก ์ด๋ํ๋๋ก ์์ - `AuthInterceptor`์์ 401 ์๋ฌ ํ ์คํธ๋ฅผ ์ํด ์์๋ก ํ ํฐ ์์ "1"์ ์ถ๊ฐ
- ๋ค์ด์ผ๋ก๊ทธ ์ข์ฐ ํจ๋ฉ ๊ฐ ์์ - ํ๋กํ ์ด๋ฏธ์ง ๋ณ๊ฒฝ ๋ฒํผ์ ๋๋น๋ฅผ `match_parent`๋ก ๋ณ๊ฒฝ
- versionCode: 8 โ 9 - versionName: 1.0.7 โ 1.0.8
- ์ฑ ์ด๋ฆ์ "FindU"์์ "์ฐพ์์ "๋ก ๋ณ๊ฒฝ - ๋ง์ดํ์ด์ง์ ์ค์ ๋ฒํผ์ ๋ณด์ด์ง ์๋๋ก ์์
- versionCode: 9 -> 11 - versionName: "1.0.8" -> "1.0.10"
- ์ฑ ๋ฒ์ ์ 1.0.10์์ 1.0.11๋ก ์ ๋ฐ์ดํธ - versionCode๋ฅผ 11์์ 12๋ก ์ ๋ฐ์ดํธ
|
Caution Review failedThe pull request is closed. Walkthrough๋ฒ์ ์ ๋ฐ์ดํธ์ ํจ๊ป 401 ์ธ์ฆ ์ค๋ฅ ์ฒ๋ฆฌ ๋ก์ง์ ์ถ๊ฐํ๊ณ , ๊ฒ์คํธ ์ฌ์ฉ์ UI ๋ถ๊ธฐ, ๋งต ๋ก๊ณ ํด๋ฆญ ๋นํ์ฑํ, ํน์ UI ์์ ์จ๊น ์ฒ๋ฆฌ๋ฅผ ํฌํจํ ๋ค์ํ UI ๋ฐ ๋คํธ์ํฌ ๊ณ์ธต ๋ณ๊ฒฝ์ฌํญ์ด ๋ฐ์๋์์ต๋๋ค. Changes
Sequence DiagramsequenceDiagram
participant Client as ํด๋ผ์ด์ธํธ (์ฑ)
participant Interceptor as AuthAuthenticator<br/>(์ธํฐ์
ํฐ)
participant TokenDS as TokenLocalDataSource
participant LoginActivity as LoginActivity
Client->>Interceptor: API ์์ฒญ ์ก์
Interceptor->>Interceptor: ์๋ต ์์
alt 401 ์๋ต ๊ฐ์ง
Interceptor->>TokenDS: clearToken()
TokenDS->>TokenDS: ์ ์ฅ๋ ํ ํฐ ์ญ์
Interceptor->>LoginActivity: startActivity()<br/>(NEW_TASK | CLEAR_TASK)
LoginActivity->>LoginActivity: ๋ก๊ทธ์ธ ํ๋ฉด ํ์
rect rgb(200, 220, 240)
note over Interceptor: ์๋ณธ ์๋ต ๋ฐํ
end
else ๋ค๋ฅธ ์ํ ์ฝ๋
rect rgb(240, 240, 240)
Interceptor->>Client: ์๋ต ํต๊ณผ
end
end
Estimated code review effort๐ฏ 3 (Moderate) | โฑ๏ธ ~20 minutes Possibly related issues
Possibly related PRs
Suggested labels
Suggested reviewers
Poem
โจ Finishing touches
๐งช Generate unit tests (beta)
๐ Recent review detailsConfiguration used: Repository UI Review profile: CHILL Plan: Pro ๐ Files selected for processing (18)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Related issue ๐
Work Description ๐
Screenshot ๐ธ
Uncompleted Tasks ๐
To Reviewers ๐ข
Summary by CodeRabbit
๋ฆด๋ฆฌ์ค ๋ ธํธ
New Features
Bug Fixes
Style
Chores
โ๏ธ Tip: You can customize this high-level summary in your review settings.