Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/profile sign out #202

Open
wants to merge 7 commits into
base: development
Choose a base branch
from
Open

Feat/profile sign out #202

wants to merge 7 commits into from

Conversation

mayorJAY
Copy link
Collaborator

What this PR does:

Handles proper navigation to and from Profile Fragment depending on if a user is signed in or not

Which issue(s) this PR fixes:

Fixes #192

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

ktlint

core/src/main/java/com/fightpandemics/core/utils/SharedPrefUtil.kt|42 col 1| Unexpected indentation (4) (should be 0)
core/src/main/java/com/fightpandemics/core/utils/SharedPrefUtil.kt|43 col 1| Unexpected indentation (8) (should be 4)
core/src/main/java/com/fightpandemics/core/utils/SharedPrefUtil.kt|44 col 1| Unexpected indentation (8) (should be 4)
core/src/main/java/com/fightpandemics/core/utils/SharedPrefUtil.kt|45 col 1| Unexpected indentation (12) (should be 8)
core/src/main/java/com/fightpandemics/core/utils/SharedPrefUtil.kt|46 col 1| Unexpected indentation (12) (should be 8)
core/src/main/java/com/fightpandemics/core/utils/SharedPrefUtil.kt|47 col 1| Unexpected indentation (12) (should be 8)
core/src/main/java/com/fightpandemics/core/utils/SharedPrefUtil.kt|48 col 1| Unexpected indentation (8) (should be 4)
core/src/main/java/com/fightpandemics/core/utils/SharedPrefUtil.kt|49 col 1| Unexpected indentation (8) (should be 4)
core/src/main/java/com/fightpandemics/core/utils/SharedPrefUtil.kt|50 col 1| Unexpected indentation (4) (should be 0)
core/src/main/java/com/fightpandemics/core/utils/SharedPrefUtil.kt|52 col 1| Unexpected indentation (4) (should be 0)
core/src/main/java/com/fightpandemics/core/utils/SharedPrefUtil.kt|53 col 1| Unexpected indentation (5) (should be 1)
core/src/main/java/com/fightpandemics/core/utils/SharedPrefUtil.kt|54 col 1| Unexpected indentation (5) (should be 1)
core/src/main/java/com/fightpandemics/core/utils/SharedPrefUtil.kt|55 col 1| Unexpected indentation (5) (should be 1)
core/src/main/java/com/fightpandemics/core/utils/SharedPrefUtil.kt|56 col 1| Unexpected indentation (5) (should be 1)
core/src/main/java/com/fightpandemics/core/utils/SharedPrefUtil.kt|57 col 1| Unexpected indentation (5) (should be 1)
core/src/main/java/com/fightpandemics/core/utils/SharedPrefUtil.kt|58 col 1| Unexpected indentation (5) (should be 1)
core/src/main/java/com/fightpandemics/core/utils/SharedPrefUtil.kt|59 col 1| Unexpected indentation (5) (should be 1)
core/src/main/java/com/fightpandemics/core/utils/SharedPrefUtil.kt|60 col 1| Unexpected indentation (4) (should be 0)
core/src/main/java/com/fightpandemics/core/utils/SharedPrefUtil.kt|61 col 1| Unexpected indentation (8) (should be 4)
core/src/main/java/com/fightpandemics/core/utils/SharedPrefUtil.kt|62 col 1| Unexpected indentation (8) (should be 4)
core/src/main/java/com/fightpandemics/core/utils/SharedPrefUtil.kt|63 col 1| Unexpected indentation (8) (should be 4)
core/src/main/java/com/fightpandemics/core/utils/SharedPrefUtil.kt|64 col 1| Unexpected indentation (4) (should be 0)
core/src/main/java/com/fightpandemics/core/utils/SharedPrefUtil.kt|65 col 1| Unexpected indentation (8) (should be 4)
core/src/main/java/com/fightpandemics/core/utils/SharedPrefUtil.kt|66 col 1| Unexpected indentation (8) (should be 4)
core/src/main/java/com/fightpandemics/core/utils/SharedPrefUtil.kt|67 col 1| Unexpected indentation (8) (should be 4)
core/src/main/java/com/fightpandemics/core/utils/SharedPrefUtil.kt|68 col 1| Unexpected indentation (12) (should be 8)
core/src/main/java/com/fightpandemics/core/utils/SharedPrefUtil.kt|69 col 1| Unexpected indentation (8) (should be 4)
core/src/main/java/com/fightpandemics/core/utils/SharedPrefUtil.kt|70 col 1| Unexpected indentation (8) (should be 4)
core/src/main/java/com/fightpandemics/core/utils/SharedPrefUtil.kt|71 col 1| Unexpected indentation (4) (should be 0)
core/src/main/java/com/fightpandemics/core/utils/SharedPrefUtil.kt|73 col 1| Unexpected indentation (4) (should be 0)
core/src/main/java/com/fightpandemics/core/utils/SharedPrefUtil.kt|74 col 1| Unexpected indentation (5) (should be 1)
core/src/main/java/com/fightpandemics/core/utils/SharedPrefUtil.kt|75 col 1| Unexpected indentation (5) (should be 1)
core/src/main/java/com/fightpandemics/core/utils/SharedPrefUtil.kt|76 col 1| Unexpected indentation (5) (should be 1)
core/src/main/java/com/fightpandemics/core/utils/SharedPrefUtil.kt|77 col 1| Unexpected indentation (5) (should be 1)
core/src/main/java/com/fightpandemics/core/utils/SharedPrefUtil.kt|78 col 1| Unexpected indentation (5) (should be 1)
core/src/main/java/com/fightpandemics/core/utils/SharedPrefUtil.kt|79 col 1| Unexpected indentation (5) (should be 1)
core/src/main/java/com/fightpandemics/core/utils/SharedPrefUtil.kt|80 col 1| Unexpected indentation (5) (should be 1)
core/src/main/java/com/fightpandemics/core/utils/SharedPrefUtil.kt|81 col 1| Unexpected indentation (4) (should be 0)
core/src/main/java/com/fightpandemics/core/utils/SharedPrefUtil.kt|82 col 1| Unexpected indentation (8) (should be 4)
core/src/main/java/com/fightpandemics/core/utils/SharedPrefUtil.kt|83 col 1| Unexpected indentation (8) (should be 4)
core/src/main/java/com/fightpandemics/core/utils/SharedPrefUtil.kt|84 col 1| Unexpected indentation (8) (should be 4)
core/src/main/java/com/fightpandemics/core/utils/SharedPrefUtil.kt|85 col 1| Unexpected indentation (4) (should be 0)
core/src/main/java/com/fightpandemics/core/utils/SharedPrefUtil.kt|86 col 1| Unexpected indentation (8) (should be 4)
core/src/main/java/com/fightpandemics/core/utils/SharedPrefUtil.kt|87 col 1| Unexpected indentation (8) (should be 4)
core/src/main/java/com/fightpandemics/core/utils/SharedPrefUtil.kt|88 col 1| Unexpected indentation (12) (should be 8)
core/src/main/java/com/fightpandemics/core/utils/SharedPrefUtil.kt|89 col 1| Unexpected indentation (12) (should be 8)
core/src/main/java/com/fightpandemics/core/utils/SharedPrefUtil.kt|90 col 1| Unexpected indentation (12) (should be 8)
core/src/main/java/com/fightpandemics/core/utils/SharedPrefUtil.kt|91 col 1| Unexpected indentation (8) (should be 4)
core/src/main/java/com/fightpandemics/core/utils/SharedPrefUtil.kt|92 col 1| Unexpected indentation (8) (should be 4)
core/src/main/java/com/fightpandemics/core/utils/SharedPrefUtil.kt|93 col 1| Unexpected indentation (4) (should be 0)
core/src/main/java/com/fightpandemics/core/utils/SharedPrefUtil.kt|95 col 1| Unexpected indentation (4) (should be 0)
core/src/main/java/com/fightpandemics/core/utils/SharedPrefUtil.kt|96 col 1| Unexpected indentation (5) (should be 1)
core/src/main/java/com/fightpandemics/core/utils/SharedPrefUtil.kt|97 col 1| Unexpected indentation (5) (should be 1)
core/src/main/java/com/fightpandemics/core/utils/SharedPrefUtil.kt|98 col 1| Unexpected indentation (5) (should be 1)
core/src/main/java/com/fightpandemics/core/utils/SharedPrefUtil.kt|99 col 1| Unexpected indentation (5) (should be 1)
core/src/main/java/com/fightpandemics/core/utils/SharedPrefUtil.kt|100 col 1| Unexpected indentation (5) (should be 1)
core/src/main/java/com/fightpandemics/core/utils/SharedPrefUtil.kt|101 col 1| Unexpected indentation (5) (should be 1)
core/src/main/java/com/fightpandemics/core/utils/SharedPrefUtil.kt|102 col 1| Unexpected indentation (5) (should be 1)
core/src/main/java/com/fightpandemics/core/utils/SharedPrefUtil.kt|103 col 1| Unexpected indentation (4) (should be 0)
core/src/main/java/com/fightpandemics/core/utils/SharedPrefUtil.kt|104 col 1| Unexpected indentation (8) (should be 4)
core/src/main/java/com/fightpandemics/core/utils/SharedPrefUtil.kt|105 col 1| Unexpected indentation (8) (should be 4)
core/src/main/java/com/fightpandemics/core/utils/SharedPrefUtil.kt|106 col 1| Unexpected indentation (8) (should be 4)
core/src/main/java/com/fightpandemics/core/utils/SharedPrefUtil.kt|107 col 1| Unexpected indentation (4) (should be 0)
core/src/main/java/com/fightpandemics/core/utils/SharedPrefUtil.kt|108 col 1| Unexpected indentation (8) (should be 4)
core/src/main/java/com/fightpandemics/core/utils/SharedPrefUtil.kt|109 col 1| Unexpected indentation (8) (should be 4)
core/src/main/java/com/fightpandemics/core/utils/SharedPrefUtil.kt|110 col 1| Unexpected indentation (8) (should be 4)
core/src/main/java/com/fightpandemics/core/utils/SharedPrefUtil.kt|111 col 1| Unexpected indentation (12) (should be 8)
core/src/main/java/com/fightpandemics/core/utils/SharedPrefUtil.kt|112 col 1| Unexpected indentation (8) (should be 4)
core/src/main/java/com/fightpandemics/core/utils/SharedPrefUtil.kt|113 col 1| Unexpected indentation (8) (should be 4)
core/src/main/java/com/fightpandemics/core/utils/SharedPrefUtil.kt|114 col 1| Unexpected indentation (4) (should be 0)
core/src/main/java/com/fightpandemics/core/utils/SharedPrefUtil.kt|116 col 1| Unexpected indentation (4) (should be 0)
core/src/main/java/com/fightpandemics/core/utils/SharedPrefUtil.kt|117 col 1| Unexpected indentation (5) (should be 1)
core/src/main/java/com/fightpandemics/core/utils/SharedPrefUtil.kt|118 col 1| Unexpected indentation (5) (should be 1)
core/src/main/java/com/fightpandemics/core/utils/SharedPrefUtil.kt|119 col 1| Unexpected indentation (5) (should be 1)
core/src/main/java/com/fightpandemics/core/utils/SharedPrefUtil.kt|120 col 1| Unexpected indentation (5) (should be 1)
core/src/main/java/com/fightpandemics/core/utils/SharedPrefUtil.kt|121 col 1| Unexpected indentation (5) (should be 1)
core/src/main/java/com/fightpandemics/core/utils/SharedPrefUtil.kt|122 col 1| Unexpected indentation (5) (should be 1)
core/src/main/java/com/fightpandemics/core/utils/SharedPrefUtil.kt|123 col 1| Unexpected indentation (5) (should be 1)
core/src/main/java/com/fightpandemics/core/utils/SharedPrefUtil.kt|124 col 1| Unexpected indentation (4) (should be 0)
core/src/main/java/com/fightpandemics/core/utils/SharedPrefUtil.kt|125 col 1| Unexpected indentation (8) (should be 4)
core/src/main/java/com/fightpandemics/core/utils/SharedPrefUtil.kt|126 col 1| Unexpected indentation (8) (should be 4)
core/src/main/java/com/fightpandemics/core/utils/SharedPrefUtil.kt|127 col 1| Unexpected indentation (8) (should be 4)
core/src/main/java/com/fightpandemics/core/utils/SharedPrefUtil.kt|128 col 1| Unexpected indentation (4) (should be 0)
core/src/main/java/com/fightpandemics/core/utils/SharedPrefUtil.kt|129 col 1| Unexpected indentation (8) (should be 4)
core/src/main/java/com/fightpandemics/core/utils/SharedPrefUtil.kt|130 col 1| Unexpected indentation (8) (should be 4)
core/src/main/java/com/fightpandemics/core/utils/SharedPrefUtil.kt|131 col 1| Unexpected indentation (12) (should be 8)
core/src/main/java/com/fightpandemics/core/utils/SharedPrefUtil.kt|132 col 1| Unexpected indentation (12) (should be 8)
core/src/main/java/com/fightpandemics/core/utils/SharedPrefUtil.kt|133 col 1| Unexpected indentation (12) (should be 8)
core/src/main/java/com/fightpandemics/core/utils/SharedPrefUtil.kt|134 col 1| Unexpected indentation (8) (should be 4)
core/src/main/java/com/fightpandemics/core/utils/SharedPrefUtil.kt|135 col 1| Unexpected indentation (8) (should be 4)
core/src/main/java/com/fightpandemics/core/utils/SharedPrefUtil.kt|136 col 1| Unexpected indentation (4) (should be 0)
core/src/main/java/com/fightpandemics/core/utils/SharedPrefUtil.kt|138 col 1| Unexpected indentation (4) (should be 0)
core/src/main/java/com/fightpandemics/core/utils/SharedPrefUtil.kt|139 col 1| Unexpected indentation (5) (should be 1)
core/src/main/java/com/fightpandemics/core/utils/SharedPrefUtil.kt|140 col 1| Unexpected indentation (5) (should be 1)
core/src/main/java/com/fightpandemics/core/utils/SharedPrefUtil.kt|141 col 1| Unexpected indentation (5) (should be 1)
core/src/main/java/com/fightpandemics/core/utils/SharedPrefUtil.kt|142 col 1| Unexpected indentation (5) (should be 1)
core/src/main/java/com/fightpandemics/core/utils/SharedPrefUtil.kt|143 col 1| Unexpected indentation (5) (should be 1)
core/src/main/java/com/fightpandemics/core/utils/SharedPrefUtil.kt|144 col 1| Unexpected indentation (5) (should be 1)
core/src/main/java/com/fightpandemics/core/utils/SharedPrefUtil.kt|145 col 1| Unexpected indentation (5) (should be 1)
core/src/main/java/com/fightpandemics/core/utils/SharedPrefUtil.kt|146 col 1| Unexpected indentation (4) (should be 0)
core/src/main/java/com/fightpandemics/core/utils/SharedPrefUtil.kt|147 col 1| Unexpected indentation (8) (should be 4)
core/src/main/java/com/fightpandemics/core/utils/SharedPrefUtil.kt|148 col 1| Unexpected indentation (8) (should be 4)
core/src/main/java/com/fightpandemics/core/utils/SharedPrefUtil.kt|149 col 1| Unexpected indentation (8) (should be 4)
core/src/main/java/com/fightpandemics/core/utils/SharedPrefUtil.kt|150 col 1| Unexpected indentation (12) (should be 8)
core/src/main/java/com/fightpandemics/core/utils/SharedPrefUtil.kt|151 col 1| Unexpected indentation (8) (should be 4)
core/src/main/java/com/fightpandemics/core/utils/SharedPrefUtil.kt|152 col 1| Unexpected indentation (8) (should be 4)
core/src/main/java/com/fightpandemics/core/utils/SharedPrefUtil.kt|153 col 1| Unexpected indentation (4) (should be 0)
core/src/main/java/com/fightpandemics/core/utils/SharedPrefUtil.kt|155 col 1| Unexpected indentation (4) (should be 0)
core/src/main/java/com/fightpandemics/core/utils/SharedPrefUtil.kt|156 col 1| Unexpected indentation (5) (should be 1)
core/src/main/java/com/fightpandemics/core/utils/SharedPrefUtil.kt|157 col 1| Unexpected indentation (5) (should be 1)
core/src/main/java/com/fightpandemics/core/utils/SharedPrefUtil.kt|158 col 1| Unexpected indentation (5) (should be 1)
core/src/main/java/com/fightpandemics/core/utils/SharedPrefUtil.kt|159 col 1| Unexpected indentation (5) (should be 1)
core/src/main/java/com/fightpandemics/core/utils/SharedPrefUtil.kt|160 col 1| Unexpected indentation (5) (should be 1)
core/src/main/java/com/fightpandemics/core/utils/SharedPrefUtil.kt|161 col 1| Unexpected indentation (5) (should be 1)
core/src/main/java/com/fightpandemics/core/utils/SharedPrefUtil.kt|162 col 1| Unexpected indentation (5) (should be 1)
core/src/main/java/com/fightpandemics/core/utils/SharedPrefUtil.kt|163 col 1| Unexpected indentation (4) (should be 0)
core/src/main/java/com/fightpandemics/core/utils/SharedPrefUtil.kt|164 col 1| Unexpected indentation (8) (should be 4)
core/src/main/java/com/fightpandemics/core/utils/SharedPrefUtil.kt|165 col 1| Unexpected indentation (8) (should be 4)
core/src/main/java/com/fightpandemics/core/utils/SharedPrefUtil.kt|166 col 1| Unexpected indentation (8) (should be 4)
core/src/main/java/com/fightpandemics/core/utils/SharedPrefUtil.kt|167 col 1| Unexpected indentation (4) (should be 0)
core/src/main/java/com/fightpandemics/core/utils/SharedPrefUtil.kt|168 col 1| Unexpected indentation (8) (should be 4)
core/src/main/java/com/fightpandemics/core/utils/SharedPrefUtil.kt|169 col 1| Unexpected indentation (8) (should be 4)
core/src/main/java/com/fightpandemics/core/utils/SharedPrefUtil.kt|170 col 1| Unexpected indentation (12) (should be 8)
core/src/main/java/com/fightpandemics/core/utils/SharedPrefUtil.kt|171 col 1| Unexpected indentation (12) (should be 8)
core/src/main/java/com/fightpandemics/core/utils/SharedPrefUtil.kt|172 col 1| Unexpected indentation (12) (should be 8)
core/src/main/java/com/fightpandemics/core/utils/SharedPrefUtil.kt|173 col 1| Unexpected indentation (8) (should be 4)
core/src/main/java/com/fightpandemics/core/utils/SharedPrefUtil.kt|174 col 1| Unexpected indentation (8) (should be 4)
core/src/main/java/com/fightpandemics/core/utils/SharedPrefUtil.kt|175 col 1| Unexpected indentation (4) (should be 0)
core/src/main/java/com/fightpandemics/core/utils/SharedPrefUtil.kt|177 col 1| Unexpected indentation (4) (should be 0)
core/src/main/java/com/fightpandemics/core/utils/SharedPrefUtil.kt|178 col 1| Unexpected indentation (5) (should be 1)
core/src/main/java/com/fightpandemics/core/utils/SharedPrefUtil.kt|179 col 1| Unexpected indentation (5) (should be 1)
core/src/main/java/com/fightpandemics/core/utils/SharedPrefUtil.kt|180 col 1| Unexpected indentation (5) (should be 1)
core/src/main/java/com/fightpandemics/core/utils/SharedPrefUtil.kt|181 col 1| Unexpected indentation (5) (should be 1)
core/src/main/java/com/fightpandemics/core/utils/SharedPrefUtil.kt|182 col 1| Unexpected indentation (5) (should be 1)
core/src/main/java/com/fightpandemics/core/utils/SharedPrefUtil.kt|183 col 1| Unexpected indentation (5) (should be 1)
core/src/main/java/com/fightpandemics/core/utils/SharedPrefUtil.kt|184 col 1| Unexpected indentation (5) (should be 1)
core/src/main/java/com/fightpandemics/core/utils/SharedPrefUtil.kt|185 col 1| Unexpected indentation (4) (should be 0)
core/src/main/java/com/fightpandemics/core/utils/SharedPrefUtil.kt|186 col 1| Unexpected indentation (8) (should be 4)
core/src/main/java/com/fightpandemics/core/utils/SharedPrefUtil.kt|187 col 1| Unexpected indentation (8) (should be 4)
core/src/main/java/com/fightpandemics/core/utils/SharedPrefUtil.kt|188 col 1| Unexpected indentation (8) (should be 4)
core/src/main/java/com/fightpandemics/core/utils/SharedPrefUtil.kt|189 col 1| Unexpected indentation (4) (should be 0)
core/src/main/java/com/fightpandemics/core/utils/SharedPrefUtil.kt|190 col 1| Unexpected indentation (8) (should be 4)
core/src/main/java/com/fightpandemics/core/utils/SharedPrefUtil.kt|191 col 1| Unexpected indentation (8) (should be 4)
core/src/main/java/com/fightpandemics/core/utils/SharedPrefUtil.kt|192 col 1| Unexpected indentation (8) (should be 4)
core/src/main/java/com/fightpandemics/core/utils/SharedPrefUtil.kt|193 col 1| Unexpected indentation (12) (should be 8)
core/src/main/java/com/fightpandemics/core/utils/SharedPrefUtil.kt|194 col 1| Unexpected indentation (8) (should be 4)
core/src/main/java/com/fightpandemics/core/utils/SharedPrefUtil.kt|195 col 1| Unexpected indentation (8) (should be 4)
core/src/main/java/com/fightpandemics/core/utils/SharedPrefUtil.kt|196 col 1| Unexpected indentation (4) (should be 0)
core/src/main/java/com/fightpandemics/core/utils/SharedPrefUtil.kt|198 col 1| Unexpected indentation (4) (should be 0)
core/src/main/java/com/fightpandemics/core/utils/SharedPrefUtil.kt|199 col 1| Unexpected indentation (5) (should be 1)
core/src/main/java/com/fightpandemics/core/utils/SharedPrefUtil.kt|200 col 1| Unexpected indentation (5) (should be 1)
core/src/main/java/com/fightpandemics/core/utils/SharedPrefUtil.kt|201 col 1| Unexpected indentation (5) (should be 1)
core/src/main/java/com/fightpandemics/core/utils/SharedPrefUtil.kt|202 col 1| Unexpected indentation (5) (should be 1)
core/src/main/java/com/fightpandemics/core/utils/SharedPrefUtil.kt|203 col 1| Unexpected indentation (5) (should be 1)
core/src/main/java/com/fightpandemics/core/utils/SharedPrefUtil.kt|204 col 1| Unexpected indentation (5) (should be 1)
core/src/main/java/com/fightpandemics/core/utils/SharedPrefUtil.kt|205 col 1| Unexpected indentation (5) (should be 1)
core/src/main/java/com/fightpandemics/core/utils/SharedPrefUtil.kt|206 col 1| Unexpected indentation (4) (should be 0)
core/src/main/java/com/fightpandemics/core/utils/SharedPrefUtil.kt|207 col 1| Unexpected indentation (8) (should be 4)
core/src/main/java/com/fightpandemics/core/utils/SharedPrefUtil.kt|208 col 1| Unexpected indentation (8) (should be 4)
core/src/main/java/com/fightpandemics/core/utils/SharedPrefUtil.kt|209 col 1| Unexpected indentation (8) (should be 4)
core/src/main/java/com/fightpandemics/core/utils/SharedPrefUtil.kt|210 col 1| Unexpected indentation (4) (should be 0)
core/src/main/java/com/fightpandemics/core/utils/SharedPrefUtil.kt|211 col 1| Unexpected indentation (8) (should be 4)
core/src/main/java/com/fightpandemics/core/utils/SharedPrefUtil.kt|212 col 1| Unexpected indentation (8) (should be 4)
core/src/main/java/com/fightpandemics/core/utils/SharedPrefUtil.kt|213 col 1| Unexpected indentation (12) (should be 8)
core/src/main/java/com/fightpandemics/core/utils/SharedPrefUtil.kt|214 col 1| Unexpected indentation (12) (should be 8)
core/src/main/java/com/fightpandemics/core/utils/SharedPrefUtil.kt|215 col 1| Unexpected indentation (12) (should be 8)
core/src/main/java/com/fightpandemics/core/utils/SharedPrefUtil.kt|216 col 1| Unexpected indentation (8) (should be 4)
core/src/main/java/com/fightpandemics/core/utils/SharedPrefUtil.kt|217 col 1| Unexpected indentation (8) (should be 4)
core/src/main/java/com/fightpandemics/core/utils/SharedPrefUtil.kt|218 col 1| Unexpected indentation (4) (should be 0)
core/src/main/java/com/fightpandemics/core/utils/SharedPrefUtil.kt|220 col 1| Unexpected indentation (4) (should be 0)
core/src/main/java/com/fightpandemics/core/utils/SharedPrefUtil.kt|221 col 1| Unexpected indentation (5) (should be 1)
core/src/main/java/com/fightpandemics/core/utils/SharedPrefUtil.kt|222 col 1| Unexpected indentation (5) (should be 1)
core/src/main/java/com/fightpandemics/core/utils/SharedPrefUtil.kt|223 col 1| Unexpected indentation (5) (should be 1)
core/src/main/java/com/fightpandemics/core/utils/SharedPrefUtil.kt|224 col 1| Unexpected indentation (5) (should be 1)
core/src/main/java/com/fightpandemics/core/utils/SharedPrefUtil.kt|225 col 1| Unexpected indentation (5) (should be 1)
core/src/main/java/com/fightpandemics/core/utils/SharedPrefUtil.kt|226 col 1| Unexpected indentation (5) (should be 1)
core/src/main/java/com/fightpandemics/core/utils/SharedPrefUtil.kt|227 col 1| Unexpected indentation (4) (should be 0)
core/src/main/java/com/fightpandemics/core/utils/SharedPrefUtil.kt|228 col 1| Unexpected indentation (8) (should be 4)
core/src/main/java/com/fightpandemics/core/utils/SharedPrefUtil.kt|229 col 1| Unexpected indentation (8) (should be 4)
core/src/main/java/com/fightpandemics/core/utils/SharedPrefUtil.kt|230 col 1| Unexpected indentation (12) (should be 8)
core/src/main/java/com/fightpandemics/core/utils/SharedPrefUtil.kt|231 col 1| Unexpected indentation (12) (should be 8)
core/src/main/java/com/fightpandemics/core/utils/SharedPrefUtil.kt|232 col 1| Unexpected indentation (12) (should be 8)
core/src/main/java/com/fightpandemics/core/utils/SharedPrefUtil.kt|233 col 1| Unexpected indentation (8) (should be 4)
core/src/main/java/com/fightpandemics/core/utils/SharedPrefUtil.kt|234 col 1| Unexpected indentation (8) (should be 4)
core/src/main/java/com/fightpandemics/core/utils/SharedPrefUtil.kt|235 col 1| Unexpected indentation (4) (should be 0)
profile/src/main/java/com/fightpandemics/profile/ui/profile/IndivProfileSettings.kt|3 col 1| Imports must be ordered in lexicographic order without any empty lines in-between with "java", "javax", "kotlin" and aliases in the end
profile/src/main/java/com/fightpandemics/profile/ui/profile/IndivProfileSettings.kt|68 col 67| Missing space after //
profile/src/main/java/com/fightpandemics/profile/ui/profile/IndivProfileSettings.kt|75 col 50| Missing space after //
profile/src/main/java/com/fightpandemics/profile/ui/profile/ProfileSignedOutFragment.kt|1 col 1| File must end with a newline (\n)

@FightPandemics FightPandemics deleted a comment from todo bot Mar 14, 2021
@FightPandemics FightPandemics deleted a comment from todo bot Mar 14, 2021
Copy link
Collaborator

@carl05 carl05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mayorjay I think is not good to call preferences from fragment becaus this bring business logic to fragment class. You should use a view module to do that. Also the shared preferences should not be directly setted from ViewModel we should create all data structure to do that because in some point we could change this to a webserver and you only need to refactor the data layer and not all others layers.

Take at AuthTokenLocalDataSourceImpl, LoginRepositoryImpl. The AuthTokenLocalDataSourceImpl is using preference storage as well. You can use this class to have a method like isLoggedIN. Refactoring this I think it will be ok to approve the PR


logInBtnWhite.setOnClickListener {
findNavController().navigate(com.fightpandemics.R.id.action_profileSignedOutFragment_to_signInFragment)
setBooleanPreference(activity?.applicationContext, "isUserSignedInFromProfile", true)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mayorjay I think is not good to call preferences from fragment becaus this bring business logic to fragment class. You should use a view module to do that. Also the shared preferences should not be directly setted from ViewModel we should create all data structure to do that because in some point we could change this to a webserver and you only need to refactor the data layer and not all others layers.

Take at AuthTokenLocalDataSourceImpl, LoginRepositoryImpl. The AuthTokenLocalDataSourceImpl is using preference storage as well. You can use this class to have a method like isLoggedIN. Refactoring this I think it will be ok to approve the PR

@todo
Copy link

todo bot commented Mar 20, 2021

add error treatment on get current profile

// TODO add error treatment on get current profile
}
}
}
}


This comment was generated by todo based on a TODO comment in b86d5a6 in #202. cc @FightPandemics.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Handle "Signout"
2 participants