Draft
Conversation
…, gas report Add comprehensive CI pipeline for cofhe-contracts with 5 parallel jobs: - Storage layout snapshot validation to catch breaking upgrade changes - Contract size enforcement (24KB EVM limit) - Solhint linting with project-specific rule overrides - Slither static analysis (medium+ severity) - Gas usage reporting uploaded as CI artifact
- Initialize `combined` variable explicitly (`bytes memory combined = ""`) - Add slither-disable comments for false-positive unused-return on ECDSA.tryRecover tuple destructuring and getDecryptResultSafe forwarding - Exclude low-severity false positives from Slither config (trusted contract calls in loops, reentrancy-events, missing-zero-check on intentionally-nullable signers, timestamp, events-maths)
…t CI) This commit intentionally adds a new storage variable to break the storage layout snapshot check. Expected CI failure: storage-layout job.
…ge-layout CI)" This reverts commit 99c1957.
…lity Replace exact JSON comparison with OZ's getStorageUpgradeReport which understands UUPS upgrade rules: appending variables is safe, inserting or reordering is breaking. Stores raw StorageLayout in snapshot for direct use by the compatibility checker.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a comprehensive CI pipeline (
checks.yml) with 5 parallel jobs to catch issues before merge. The existingtest.ymlis untouched.allowUnlimitedContractSize: true)hardhat-gas-reporterand uploads the report as a CI artifactNew Files
.github/workflows/checks.ymltasks/storageLayout.ts@openzeppelin/upgrades-coretasks/checkContractSize.ts.solhint.jsonsolhint:recommended).solhintignorenode_modules/,contracts/tests/,contracts/detereministic-tm/slither.config.jsonstorage-layout-snapshot.jsonModified Files
tasks/index.tspackage.jsonsolhintdevDep + scripts:storage-layout:generate,storage-layout:check,check:size,lint:solhardhat.config.tsgasReporterconfig (gated byREPORT_GASenv var)New Scripts
Local Verification
All checks pass locally:
Current Contract Sizes
Notes
Stringsimport inTaskManager.solas a warning (not error). Consider removing it in a follow-up.crytic/slither-action@v0.4.0with solc 0.8.25 pinned.Test plan
checks.ymlCI jobs all pass on this PRtest.ymlis unaffectedstorage-layout:checkfails