Fix(#291): InstantDeserializer fails to parse negative numeric timestamp strings for pre-1970 values #362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Full Issue Title: InstantDeserializer fails to parse negative numeric timestamp strings for pre-1970 values. - Updated `InstantDeserializer._countPeriods(String)` to check for `-` and `+` at beginning of numeric string. - Additionally, added check if `ALLOW_LEADING_PLUS_SIGN_FOR_NUMBERS` is enabled. If disabled, throws same exception as before change from `_countPeriods(...)`. - Moved associated tests out of `failing` directory
|
Would it be better to explicitly throw a |
cowtowncoder
reviewed
Mar 4, 2025
datetime/src/main/java/com/fasterxml/jackson/datatype/jsr310/deser/InstantDeserializer.java
Outdated
Show resolved
Hide resolved
cowtowncoder
reviewed
Mar 4, 2025
datetime/src/main/java/com/fasterxml/jackson/datatype/jsr310/deser/InstantDeserializer.java
Outdated
Show resolved
Hide resolved
I think this is ok. Parsing numbers from Strings is bit icky anyway. |
Changed the function signature of `_countPeriods(JsonParser, String)` to `_countPeriods(String, boolean)` per suggestion from user cowtowncoder
cowtowncoder
approved these changes
Mar 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #291:
InstantDeserializer._countPeriods(String)to check for-and+at beginning of numeric string.ALLOW_LEADING_PLUS_SIGN_FOR_NUMBERSis enabled. If disabled, throws same exception as before change from_countPeriods(...).failingdirectory and then moved todeserdirectory.