Fix #4994 CoercionConfig for CoercionAction.AsNull not working on empty array deserialization
#4999
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -179,6 +179,22 @@ public String[] deserialize(JsonParser p, DeserializationContext ctxt) throws IO | |||
| } | |||
| String[] result = buffer.completeAndClearBuffer(chunk, ix, String.class); | |||
| ctxt.returnObjectBuffer(buffer); | |||
| if (result != null) { | |||
There was a problem hiding this comment.
Can never be null, let's remove check.
|
Should probably cover a few other types if we do this: specifically test
although I think both of these are handled by There are also ~7 or so primitive array deserializers but we can defer those I think. |
Never mind, decided to cover here |
1 task
JooHyukKim
changed the title
CoercionConfig not working on String[] CoercionConfig not working on Array deserialization
JooHyukKim
changed the title
CoercionConfig not working on Array deserializationCoercionConfig for CoercionAction.AsNull not working on empty array deserialization
|
@JooHyukKim Apologies for wasted work here -- only now realized this is not how |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #4994