Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Java Assignment3 upload by LeeJaewon #32

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Java Assignment3 upload by LeeJaewon #32

wants to merge 2 commits into from

Conversation

Pull-Stack
Copy link

Assignment3

  1. User 클래스 작성
  2. Electronic 클래스 작성
  3. Users 클래스 작성
  4. Electronics 클래스 작성

@Pull-Stack Pull-Stack requested a review from ecsimsw April 17, 2023 14:09
ecsimsw
ecsimsw approved these changes Apr 21, 2023
View reviewed changes
Copy link
Member

@ecsimsw ecsimsw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다.

me/day05/practice/Electronics.java

private Electronics() {

}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

굳

me/day05/practice/Electronics.java

Electronic[] groupByCompanyName(Company company) {
return Arrays.stream(this.electronicList)
.filter(electronic -> electronic.getCompanyName().equals(company))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CompanyName과 Company 용어를 통일하면 어떨까요?
getCompanyName()으로 Company를 반환하니 헷갈리네요.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

네 반환되는 값이 Company array이니 메소드명을 groupByCompany()으로 바꾸는게 좋아보입니다!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ecsimsw ecsimsw ecsimsw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Pull-Stack @ecsimsw