Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Weekly release main 30-01-2024 #978

Merged
merged 3 commits into from
Jan 30, 2024
Merged

Weekly release main 30-01-2024 #978

merged 3 commits into from
Jan 30, 2024

Conversation

dnamorim
Copy link
Contributor

Description

Weekly release

Dependencies

Checklist

  • The commit message follows our guidelines
  • Tests for the respective changes have been added
  • The code is commented, particularly in hard-to-understand areas
  • The labels and/or milestones were added

Disclaimer

By sending us your contributions, you are agreeing that your contribution is made subject to the terms of our Contributor Ownership Statement

@github-actions github-actions bot added 📦 analytics Relative to the `@farfetch/blackout-analytics` package 📦 react Relative to the `@farfetch/blackout-react` package labels Jan 26, 2024
- Set up analytics behavior for referrer attribution in SPA;
- Fix additional issues related to analytics context in tracking events;
- Fix inconsistencies in analytics tests.
Bruno Oliveira and others added 2 commits January 30, 2024 15:44
This fixes a problem where if two or more consecutive calls
to analytics.page are added before the microtask queue has an
opportunity to run, the same values for the `uniqueViewId`
and `previousUniqueViewId` parameters for both the Omnitracking
events that would be generated. While this works, this is a temporary
fix since there are other values that suffer from the same problem,
for example, the consent and user values can be affected since they
are globally shared. A deeper change to analytics would be needed
to tackle this but as this is not a very common case, we will leave it
like that for now.
@github-actions github-actions bot added the 📦 redux Relative to the `@farfetch/blackout-redux` package label Jan 30, 2024
@boliveira boliveira merged commit 6df0a30 into main Jan 30, 2024
3 checks passed
@boliveira boliveira deleted the dev-main-23-01-24 branch January 30, 2024 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📦 analytics Relative to the `@farfetch/blackout-analytics` package 📦 react Relative to the `@farfetch/blackout-react` package 📦 redux Relative to the `@farfetch/blackout-redux` package
Development

Successfully merging this pull request may close these issues.

4 participants