Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add parity between ga4 and gtm for main #977

Merged

Conversation

talbertosilva
Copy link

Description

  • Added changes to guarantee a better parity between ga4 and gtm tracking, this involves the addition of events that weren't being tracked on gtm and the respective parameters based on ga4 trackings.
  • Changed needed utils functions that are directly related with the trackings as well.
  • Implemented and adjusted the unit tests affected by this changes.

Dependencies

None.

Checklist

  • The commit message follows our guidelines
  • Tests for the respective changes have been added
  • The code is commented, particularly in hard-to-understand areas
  • The labels and/or milestones were added

Disclaimer

By sending us your contributions, you are agreeing that your contribution is made subject to the terms of our Contributor Ownership Statement

@talbertosilva talbertosilva added the type: feature New feature label Jan 26, 2024
@talbertosilva talbertosilva added this to the dev-main-23-01-24 milestone Jan 26, 2024
@talbertosilva talbertosilva self-assigned this Jan 26, 2024
@talbertosilva talbertosilva changed the title feat: add parity between ga4 and gtm for main WIP: feat: add parity between ga4 and gtm for main Jan 26, 2024
@github-actions github-actions bot added 📦 analytics Relative to the `@farfetch/blackout-analytics` package 📦 react Relative to the `@farfetch/blackout-react` package type: feature New feature and removed type: feature New feature labels Jan 26, 2024
@dnamorim dnamorim force-pushed the dev-main-23-01-24 branch 2 times, most recently from b13724c to 1729a08 Compare January 26, 2024 14:36
@talbertosilva talbertosilva force-pushed the feat_add_parity_between_ga4_and_gtm_main branch from e51c0ad to aa1ba54 Compare January 29, 2024 10:31
@talbertosilva talbertosilva changed the title WIP: feat: add parity between ga4 and gtm for main feat: add parity between ga4 and gtm for main Jan 29, 2024
Base automatically changed from dev-main-23-01-24 to main January 30, 2024 17:39
@boliveira boliveira changed the base branch from main to dev-main-06-02-2024 January 30, 2024 17:42
@talbertosilva talbertosilva force-pushed the feat_add_parity_between_ga4_and_gtm_main branch from aa1ba54 to 7c060e0 Compare January 31, 2024 15:40
@github-actions github-actions bot added type: feature New feature and removed type: feature New feature labels Jan 31, 2024
@talbertosilva talbertosilva force-pushed the feat_add_parity_between_ga4_and_gtm_main branch from 7c060e0 to 2bf8c00 Compare January 31, 2024 18:10
@github-actions github-actions bot added type: feature New feature and removed type: feature New feature labels Jan 31, 2024
@talbertosilva talbertosilva force-pushed the feat_add_parity_between_ga4_and_gtm_main branch from 2bf8c00 to 116fcb7 Compare February 5, 2024 10:16
@github-actions github-actions bot added type: feature New feature and removed type: feature New feature labels Feb 5, 2024
@talbertosilva talbertosilva force-pushed the feat_add_parity_between_ga4_and_gtm_main branch from 116fcb7 to 07efaa4 Compare February 5, 2024 11:09
@github-actions github-actions bot added type: feature New feature and removed type: feature New feature labels Feb 5, 2024
@talbertosilva talbertosilva force-pushed the feat_add_parity_between_ga4_and_gtm_main branch from 07efaa4 to 711b8f1 Compare February 5, 2024 11:21
@github-actions github-actions bot added type: feature New feature and removed type: feature New feature labels Feb 5, 2024
@talbertosilva talbertosilva force-pushed the feat_add_parity_between_ga4_and_gtm_main branch from 711b8f1 to 3d6147d Compare February 5, 2024 11:35
@github-actions github-actions bot added type: feature New feature and removed type: feature New feature labels Feb 5, 2024
@talbertosilva talbertosilva force-pushed the feat_add_parity_between_ga4_and_gtm_main branch from 3d6147d to d8d4fe0 Compare February 6, 2024 09:56
@github-actions github-actions bot added type: feature New feature and removed type: feature New feature labels Feb 6, 2024
@talbertosilva talbertosilva force-pushed the feat_add_parity_between_ga4_and_gtm_main branch from d8d4fe0 to 9682200 Compare February 6, 2024 10:30
@github-actions github-actions bot added type: feature New feature and removed type: feature New feature labels Feb 6, 2024
@talbertosilva talbertosilva force-pushed the feat_add_parity_between_ga4_and_gtm_main branch from 9682200 to 2f2ec98 Compare February 6, 2024 14:21
@github-actions github-actions bot added type: feature New feature and removed type: feature New feature labels Feb 6, 2024
@dnamorim dnamorim merged commit e6c6c40 into dev-main-06-02-2024 Feb 6, 2024
3 checks passed
@dnamorim dnamorim deleted the feat_add_parity_between_ga4_and_gtm_main branch February 6, 2024 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📦 analytics Relative to the `@farfetch/blackout-analytics` package 📦 react Relative to the `@farfetch/blackout-react` package type: feature New feature
Development

Successfully merging this pull request may close these issues.

4 participants