feat: add parity between ga4 and gtm for v1
#975
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- update fields on `order_completed` event contract of GA4 and Omnitracking integration to add new fields.
- @farfetch/[email protected] - @farfetch/[email protected]
This updates the github release title format to remove the `Release` string from it and use only the tag name as it will be the new default for the `main` releases.
- @farfetch/[email protected]
This fixes the exchanges result reducer by changing the return from action.payload.result to action.payload.
- @farfetch/[email protected]
- @farfetch/[email protected]
- @farfetch/[email protected]
- Update omnitracking contract to v17.
- remove invalid fields (started with "_") of ga4 analytics integration.
- Add analytics versions field to omnitracking output payload.
- @farfetch/[email protected] - @farfetch/[email protected]
- @farfetch/[email protected]
- add new parameter `page number` for cases of endlessScrolling in interact content events (scrolling)
- @farfetch/[email protected] - @farfetch/[email protected]
github-actions
bot
added
type: feature
dnamorim
approved these changes
Jan 26, 2024
talbertosilva
force-pushed
the
feat_add_parity_between_ga4_and_gtm_v1
branch
from
2bbe2e7 to
4760943
Compare
github-actions
bot
added
type: feature
talbertosilva
force-pushed
the
feat_add_parity_between_ga4_and_gtm_v1
branch
from
4760943 to
d00158f
Compare
github-actions
bot
added
type: feature
| const properties = getEventProperties(data); | ||
|
|
||
| return { | ||
| products: get(properties, 'products', []).map(getProductData), | ||
| orderId: properties.orderId, | ||
| total: properties.total, |
There was a problem hiding this comment.
I think this property total could be missing.
I understand that was "replaced" by value, but for full compatibility, I think we need to guarantee that total stay on payload, so I suggest on new method, add total value, mapping to new value property.
Note: this could be relevant if some tenat had previous third party integration that use this specific event, and this specific value.
There was a problem hiding this comment.
Fixed! I've added a verification on getEventTotalValue method to check if total exists and, if so, map that to value property.
talbertosilva
force-pushed
the
feat_add_parity_between_ga4_and_gtm_v1
branch
from
d00158f to
3e7177e
Compare
github-actions
bot
added
type: feature
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Dependencies
None.
Checklist
Disclaimer
By sending us your contributions, you are agreeing that your contribution is made subject to the terms of our Contributor Ownership Statement