Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add delivery bundles usecheckout #930

Merged
merged 5 commits into from
Dec 5, 2023
Merged

feat: add delivery bundles usecheckout #930

merged 5 commits into from
Dec 5, 2023

Conversation

escabora
Copy link
Contributor

@escabora escabora commented Nov 28, 2023 •
edited by anapim
Loading

Description

We understand that the responsibility for exposing delivery bundles data lies with useCheckout. So I opened this PR in which I get the delivery bundles in the context of redux and expose it in the useCheckout hook. I also take the opportunity to add a key to the useCheckout that represents which delivery bundle has been selected.

Dependencies

Checklist

  • The commit message follows our guidelines
  • Tests for the respective changes have been added
  • The code is commented, particularly in hard-to-understand areas
  • The labels and/or milestones were added

Disclaimer

By sending us your contributions, you are agreeing that your contribution is made subject to the terms of our Contributor Ownership Statement

@escabora escabora added status: completed Nothing further to be done with this issue. Awaiting to be closed by the requester out of politeness 📦 react Relative to the `@farfetch/blackout-react` package labels Nov 28, 2023
@escabora escabora added this to the dev-main-28-11-23 milestone Nov 28, 2023
@escabora escabora self-assigned this Nov 28, 2023
@escabora escabora force-pushed the feat-add-delivery-bundles-usecheckout branch from d3857ce to 36dee32 Compare November 28, 2023 10:15
@escabora escabora requested a review from ivomota November 28, 2023 10:52
@escabora escabora force-pushed the feat-add-delivery-bundles-usecheckout branch 3 times, most recently from a63f65c to 7f2ac62 Compare November 28, 2023 17:28
@escabora escabora force-pushed the feat-add-delivery-bundles-usecheckout branch from 7f2ac62 to 54794bb Compare November 28, 2023 17:50
@escabora escabora changed the title Feat add delivery bundles usecheckout feat: add delivery bundles usecheckout Nov 29, 2023
anapim
anapim suggested changes Nov 29, 2023
View reviewed changes
packages/react/src/checkout/hooks/useCheckout.ts Outdated Show resolved Hide resolved
tests/__fixtures__/checkout/checkout.fixtures.mts Outdated Show resolved Hide resolved
@dnamorim dnamorim self-requested a review November 29, 2023 11:53
@github-actions github-actions bot added the type: feature New feature label Nov 30, 2023
@github-actions github-actions bot added 📦 redux Relative to the `@farfetch/blackout-redux` package type: feature New feature and removed type: feature New feature labels Nov 30, 2023
@anapim anapim removed the status: completed Nothing further to be done with this issue. Awaiting to be closed by the requester out of politeness label Nov 30, 2023
@escabora escabora changed the base branch from dev-main-28-11-23 to dev-v1-05-12-23 December 3, 2023 13:11
@github-actions github-actions bot added type: feature New feature 📦 core Relative to the `@farfetch/blackout-core` package type: documentation Changes to documentation only type: maintenance Ensures the proper functioning of the repo and removed type: feature New feature 📦 react Relative to the `@farfetch/blackout-react` package labels Dec 3, 2023
@escabora escabora force-pushed the feat-add-delivery-bundles-usecheckout branch from 5ea9f44 to b9ed58d Compare December 3, 2023 13:16
@github-actions github-actions bot added type: feature New feature and removed type: feature New feature type: documentation Changes to documentation only labels Dec 3, 2023
@escabora escabora changed the base branch from dev-v1-05-12-23 to dev-main-28-11-23 December 3, 2023 13:17
@github-actions github-actions bot added the type: documentation Changes to documentation only label Dec 3, 2023
@dnamorim dnamorim self-requested a review December 4, 2023 11:59
@github-actions github-actions bot added 📦 react Relative to the `@farfetch/blackout-react` package type: feature New feature and removed type: feature New feature type: documentation Changes to documentation only type: maintenance Ensures the proper functioning of the repo labels Dec 5, 2023
@dnamorim dnamorim merged commit 0b365fe into dev-main-28-11-23 Dec 5, 2023
3 checks passed
@dnamorim dnamorim deleted the feat-add-delivery-bundles-usecheckout branch December 5, 2023 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@boliveira boliveira boliveira approved these changes

@dnamorim dnamorim dnamorim approved these changes

@anapim anapim anapim approved these changes

@ruifcnunes ruifcnunes Awaiting requested review from ruifcnunes

@tiagodicosta tiagodicosta Awaiting requested review from tiagodicosta

@ivomota ivomota Awaiting requested review from ivomota

Assignees

@escabora escabora

Labels
📦 core Relative to the `@farfetch/blackout-core` package 📦 react Relative to the `@farfetch/blackout-react` package 📦 redux Relative to the `@farfetch/blackout-redux` package type: feature New feature
Milestone
dev-main-28-11-23
Development

Successfully merging this pull request may close these issues.
5 participants
@escabora @boliveira @ivomota @dnamorim @anapim