Repository navigation
[Docs][ROCm] Proposal: a shared kernel substrate for persistent mono decode kernels - #54
Draft
Fangzhou-Ai wants to merge 2 commits into
Draft
Fangzhou-Ai wants to merge 2 commits into
Fangzhou-Ai wants to merge 2 commits into
Conversation
…decode kernels Draft design note, static analysis only (no GPU run): the mono PRs for DeepSeek-V4.x, Kimi-K3, Qwen3.8, GLM-5.x and MiniMax-M3 each carry their own copy of the mailbox / epoch / peer-memory / build-key / device-helper plumbing. The note inventories the copies, lists where their contracts diverge, and proposes a substrate with compile-time policies, a home, and a phased migration gated by a compile-only machine-code diff. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Signed-off-by: Fangzhou Ai <fangzhou.ai@amd.com>
…poch contract Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Signed-off-by: Fangzhou Ai <fangzhou.ai@amd.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
A draft design note, doc only, stacked on
dsv4-pro-mono(vllm-project#61482): a shared kernel substrate for the persistent ("mono") decode kernels. The note isdocs/design/mono_kernel_substrate.md. It is meant for discussion in this fork first; it does not touch any code.Related: RFC vllm-project#60904, vllm-project#61311 (the runtime-layer draft), vllm-project#60397, vllm-project#61482.
What it argues
Mailboxconstructors, and build keys that exist in some copies and not in others.Mailboxclasses (attention/device.pyandcommon/sync.py), which is the cheapest place to start.atom/monodevice/plan/runtime layering as the API baseline, consolidation inside vLLM first, and a phased migration (P0-P4) gated by a compile-only machine-code diff.What to review
Validation
None, by design: this is static analysis (no GPU was available). Nothing was compiled, run or measured; the note lists what each migration phase must show before it can land. PR heads and reference-repo commits that were read are listed in the note's "Method and caveats" section.
AI assistance (Claude Code) was used to investigate the codebases and to write the note; the submitter has not yet reviewed every statement, so claims about other authors' PRs should be read as unconfirmed.
🤖 Generated with Claude Code