feat: Complete TypeDescriptor support implementation for SingletonObjectRegistry#188
Open
QwQ-dev wants to merge 2 commits intoFairyProject:v0.7from
Open
feat: Complete TypeDescriptor support implementation for SingletonObjectRegistry#188QwQ-dev wants to merge 2 commits intoFairyProject:v0.7from
QwQ-dev wants to merge 2 commits intoFairyProject:v0.7from
Conversation
LeeGodSRC
reviewed
Jun 27, 2025
Member
LeeGodSRC
left a comment
LeeGodSRC
left a comment
There was a problem hiding this comment.
Code looks good to me! but the tests are failing, can you take a look into those?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Complete TypeDescriptor support implementation by finishing all remaining TODOs from issue #182 for full generic dependency injection.