Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit para arreglar el problema de que laravel prompt no soportan Windows.
Lo que hace este fix es manejar la excepción de "No soportado" en los casos en los que se use Windows (puede haber otro sistema operativo que no lo soporte).
El código de la pr no es muy bonito pero su función es simple, reemplazar cada componente con llamadas personalizadas, es lo más rápido que se puede hacer, otras soluciones englobarían mucho más tiempo.
Aparte de añadir el fallback también se ha refactorizado el método askYesOrNo para que estén en minuscula (de esta manera el usuario tendrá más comodidad al escribir)