Skip to content

Fix no asking view #73

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
NeoRazorX merged 2 commits into from
Mar 4, 2026
Merged

Fix no asking view #73

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0d2c2c3
fix: incorrect view template format
abdedarghal111 Mar 4, 2026
7e07715
fix: not asking before creating view
abdedarghal111 Mar 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions samples/Controller.php.sample
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,8 +27,8 @@ class [[NAME]] extends Controller
{
parent::run();

$this->view('[[NAME]].html.twig');

// tu código aquí

$this->view('[[NAME]].html.twig');
}
}
37 changes: 25 additions & 12 deletions src/Command/Controller/ControllerCommand.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@

use function Laravel\Prompts\select;
use function Laravel\Prompts\text;
use function Laravel\Prompts\confirm;

#[AsCommand(
name: 'controller',
Expand Down Expand Up @@ -92,26 +93,38 @@ private function createController(string $name): void
hint: 'El nombre que se colocará en "$data[\'menu\'] = \'NOMBRE_ELEGIDO\';", por defecto es "admin".'
);

$createView = 'Si' === Utils::promptYesOrNo(
label: '¿Desea añadir la vista twig?'
);

$samplePath = dirname(__DIR__, 3) . "/samples/Controller.php.sample";
$sample = file_get_contents($samplePath);

if (!$createView) {
$search = "\n\n \$this->view('[[NAME]].html.twig');";
$sample = str_replace($search, '', $sample);
}

$template = str_replace(['[[NAME_SPACE]]', '[[NAME]]', '[[MENU]]'], [Utils::getNamespace(), $name, $menu], $sample);
Utils::createFolder($filePath);
file_put_contents($fileName, $template);
Utils::echo('* ' . $fileName . " -> OK.\n");

$viewPath = Utils::isCoreFolder() ? 'Core/View/' : 'View/';
$viewFilename = $viewPath . $name . '.html.twig';
Utils::createFolder($viewPath);
if (file_exists($viewFilename)) {
Utils::echo('* ' . $viewFilename . " YA EXISTE.\n");
return;
if ($createView) {
$viewPath = Utils::isCoreFolder() ? 'Core/View/' : 'View/';
$viewFilename = $viewPath . $name . '.html.twig';
Utils::createFolder($viewPath);
if (file_exists($viewFilename)) {
Utils::echo('* ' . $viewFilename . " YA EXISTE.\n");
return;
}

$samplePath2 = dirname(__DIR__, 3) . "/samples/View.html.twig.sample";
$sample2 = file_get_contents($samplePath2);
$template2 = str_replace('[[NADA_A_REEMPLAZAR]]', $name, $sample2);
file_put_contents($viewFilename, $template2);
Utils::echo('* ' . $viewFilename . " -> OK.\n");
}

$samplePath2 = dirname(__DIR__, 3) . "/samples/View.html.twig.sample";
$sample2 = file_get_contents($samplePath2);
$template2 = str_replace('[[NADA_A_REEMPLAZAR]]', $name, $sample2);
file_put_contents($viewFilename, $template2);
Utils::echo('* ' . $viewFilename . " -> OK.\n");
}

private function createEditController(string $modelName, array $fields): void
Expand Down