Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compile workflow #155

Closed
wants to merge 12 commits into from
Closed

Fix compile workflow #155

wants to merge 12 commits into from

Conversation

fschledorn
Copy link
Collaborator

@fschledorn fschledorn commented Nov 24, 2024

Pull Request: Enhancements and Fixes for Compile Workflow

This pull request introduces a series of enhancements and bug fixes aimed at improving the reliability and efficiency of the compile workflow.

Key improvements:

  • Resolved Build Failure (Temporary Fix Only): A function impacting the build workflow has been temporarily disabled to ensure successful compilation. ⚠️ This is a temporary workaround and requires a permanent solution before release. ⚠️ Pls See Workflow running out of memory? #154 for more details
  • Dependency Updates:
    • Updated checkout and texlive actions to the lates release
    • Updated the texlive version to the latest release
  • Fixed LaTeX Parsing: Resolved an issue related to the parsing of LaTeX escape characters, ensuring accurate interpretation and rendering of special symbols
  • File Management:
    • Corrected a missing file dependency and rectified an instance of file misnaming
    • Refactored file names to fit the new project structure
    • Rectified a misspelled folder name
    • Added empty dummy files that have not yet been written or restructured
    • Rewrote the .gitignore file to exclude compiled artifacts and IDE-generated folders

Important Notice for People writing branches

If you are working on other branches, please ensure you update your local branch with the changes from this pull request before continuing your work. This will prevent potential conflicts and ensure consistency across the project.

You can update your branch using the following commands:

git switch <your_branch_name>
git rebase origin/fix_compile_workflow

@fschledorn fschledorn added bug enhancement help wanted fix_before_vorkurs25 Sollte am besten vor dem Vorkurs in 2025 gefixt werden labels Nov 24, 2024
@fschledorn fschledorn self-assigned this Nov 24, 2024
@calvalre calvalre marked this pull request as ready for review November 25, 2024 09:09
Copy link

@calvalre calvalre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, though concerning the output pdf file, the order of the sections and subsections got a bit messed up. It currently has all the "lektionen" as subsections of "Vorbereitung eigener Computer", thereby making it kind of messy and now showing the header of each lection. Didn't immediately see what caused it though.

@fschledorn
Copy link
Collaborator Author

Looks good, though concerning the output pdf file, the order of the sections and subsections got a bit messed up. It currently has all the "lektionen" as subsections of "Vorbereitung eigener Computer", thereby making it kind of messy and now showing the header of each lection. Didn't immediately see what caused it though.

I know what the issue is. I’ll fix it in a sec

@fschledorn fschledorn deleted the branch master November 25, 2024 17:57
@fschledorn fschledorn closed this Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug enhancement fix_before_vorkurs25 Sollte am besten vor dem Vorkurs in 2025 gefixt werden help wanted
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Workflow running out of memory? fix workflow on new features 2025
2 participants