Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for running the production client with the tracy profiler. #1244

Merged
merged 3 commits into from
Jan 4, 2025

Conversation

modmuss50
Copy link
Member

There is no default tracy-capture path, as there is no standard way of building/installing it.

@modmuss50
Copy link
Member Author

On MacOS the changes in this PR work as expected, but on Linux where I want to be able to use this the most the game stalls when shutting down. I believe this is caused by: wolfpld/tracy#943 or at least something very similar, as I dont have symbols for Mojang's own natives its hard to tell. I also don't know if Mojang's own natives are built with TRACY_HAS_CALLSTACK=0 or not, I expect they are. The ones I created my self stall when launching here:

https://github.com/wolfpld/tracy/blob/5d542dc09f3d9378d005092a4ad446bd405f819a/public/client/TracyProfiler.cpp#L2047-L2049

so I can see why Mojang might have disabled it, leading to the linked issue. I dont want to add a feature to loom that requires custom tracy natives, so until this is fixed in tracy, released and Mojang updates I dont think we can do this.

@modmuss50
Copy link
Member Author

I realised the workaround in in the tracy issue only needs to be applied to the capture server, so this can be fixed without modifying the game :)

@modmuss50 modmuss50 merged commit e1cc6f0 into FabricMC:exp/1.10 Jan 4, 2025
89 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant