Only validate loom version when mixins are to be remapped with TinyRemapper #1168
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think there is an inversion in the logic introduced in #980
The comments for
MixinRemapType.STATIC
say "Jar does not use refmaps, so will be remapped by tiny-remapper"And the comments for
validateLoomVersion
say "This is only done for jars with tiny-remapper remapped mixins."So I think the logic should be checking
== STATIC
instead of!= STATIC