Fix vanilla bug preventing adding optional elements to tag in datagen #5148
+11
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ekulxam
approved these changes
Jan 20, 2026
modmuss50
approved these changes
Jan 20, 2026
Member
|
Looks great, thanks. Does this apply just to 26.1 or do you need it backporting? |
Contributor
Author
|
I don't really need this fix for anything specific, I just noticed it while testing my library. |
Author
|
There's probably someone who might find a backport useful though |
Member
|
I tend to only backport stuff if people actually want it, I'll just merge into 26.1 for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In vanilla, there is a datagen bug where
TagAppender$2#addOptionalcallsTagAppender#addinstead ofTagAppender#addOptional. This means that anyTagAppenderproduced byTagAppender#map, such asFabricIntrinsicHolderTagsProvider#valueLookupBuilder, cannot add optional elements as they are handled like required elements. This PR fixes that bug.This is my first PR so please let me know if the inject should be moved to a different mixin or if it needs tests or other style issues.