Skip to content
This repository has been archived by the owner on Jun 8, 2024. It is now read-only.

Skip synthetic classes #31

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Skip synthetic classes #31

wants to merge 1 commit into from

Conversation

modmuss50
Copy link
Member

Should Fix #30

@modmuss50 modmuss50 added the bug Something isn't working label May 20, 2023
@modmuss50 modmuss50 requested a review from liach May 20, 2023 20:24
@modmuss50
Copy link
Member Author

This might not actually be correct tbh, im not sure if/how javadoc handles the package info classes?

@liach
Copy link
Collaborator

liach commented May 20, 2023

FYI we have custom package-info files in yarn, so removing mojang ones is totally fine.

@modmuss50
Copy link
Member Author

Yeah, we cannot do anything with them in yarn. This crash was only found in a single specific mc version.

liach
liach approved these changes May 21, 2023
View reviewed changes
Copy link
Collaborator

@liach liach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be good. If this flag check fails, this whole library would have fallen apart way before (for broken inner classes, etc.)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@thecatcore thecatcore thecatcore approved these changes

@liach liach liach approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

MappingsPoet crash when handling class named "package-info"
3 participants
@modmuss50 @liach @thecatcore