Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Components & Modularization #7

Open
wants to merge 16 commits into
base: master
Choose a base branch
from
Open

Components & Modularization #7

wants to merge 16 commits into from

Conversation

martindale
Copy link
Member

@martindale martindale commented Apr 8, 2023

General cleanup

Goals

  • Web Components
  • Modularization of browser.js content
  • Multiplayer
    • Fabric Bridge
  • Chat
    • UI MVP
    • Fabric Message
    • Fabric Bridge
  • Account Service
  • GraphQL Service

Next Steps

  • Refactor logic from scripts/browser.js to types/client.js or similar
  • Cookies (remember audio preference)

@codecov-commenter
Copy link

codecov-commenter commented Apr 8, 2023

Codecov Report

Patch coverage: 33.33% and project coverage change: +19.11 🎉

Comparison is base (625f278) 43.45% compared to head (ec034a9) 62.56%.

Additional details and impacted files
@@             Coverage Diff             @@
##           master       #7       +/-   ##
===========================================
+ Coverage   43.45%   62.56%   +19.11%     
===========================================
  Files           6        6               
  Lines         741      764       +23     
===========================================
+ Hits          322      478      +156     
+ Misses        419      286      -133     
Impacted Files Coverage Δ
types/universe.js 31.25% <13.63%> (+4.43%) ⬆️
types/core.js 86.71% <100.00%> (+42.22%) ⬆️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@martindale martindale marked this pull request as ready for review April 14, 2023 15:00
@martindale martindale requested review from melnx and chrisinajar April 17, 2023 23:58
@martindale martindale self-assigned this May 6, 2023
@martindale martindale added the enhancement New feature or request label May 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Backlog
Development

Successfully merging this pull request may close these issues.

2 participants