Draft
Conversation
additionally, this commit introduces refactorings to the storage subsystem and introduces differences between filenames and paths which were handled differently before. a method was deprecated by introducing these changes
pgritsch
commented
Jan 15, 2024
| String region = m.group(3); | ||
| if (region == null || region.isEmpty() || region.isBlank()) { | ||
| return null; | ||
| return AWS_DEFAULT_REGION_WITHOUT_NAME_IN_URL; |
Member
Author
There was a problem hiding this comment.
this is still wrong, i found EU URLs without region specifier
pgritsch
force-pushed
the
main
branch
2 times, most recently
from
f42f502 to
4b47f2b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
additionally, this commit introduces refactorings to the storage subsystem and introduces differences between filenames and paths which were handled differently before. a method was deprecated by introducing these changes