Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three bugs from the Forge audit report.
Fix 3 —
status.py:49crash when memory was synced (B1)_data["memory"]is a flat dict{file_path, checksum, synced_at, ...}. The code iterated.values()treating it as a dict-of-dicts (likeskills/linked_skills), then called.get("file_path")on strings —AttributeErroron every status call after a memory sync.Fix 4 —
sync_helpers.pyper-tool success counter (B2)total_copy/total_linkaccumulated across all tools in the loop, so the success message showed cumulative totals: "5 copied", "10 copied", "15 copied" for 3 tools × 5 skills. Now usestool_copy/tool_linklocal variables for the message while still accumulating into the returned totals.Fix 5 —
export_import.pysilent plaintext export when pyrage absent (B3)Previously logged two warnings and continued exporting — secrets written in plaintext with no user acknowledgement. Now calls
error()+raise SystemExit(1). The--no-secretsflag is the documented opt-out.Updated
test_export_import.py:test_export_creates_structureandtest_export_writes_cache_datanow pass--no-secrets(correct user flow when pyrage unavailable)test_export_fails_loudly_without_pyrage— asserts non-zero exit and no export dir createdtest_export_no_secrets_succeeds_without_pyrage— asserts--no-secretsstill worksTests
122 passing (120 original + 2 new).