Reset rate limiter state when merchant plan is upgraded#238
Open
agnesadoga-creator wants to merge 1 commit into
Open
Reset rate limiter state when merchant plan is upgraded#238agnesadoga-creator wants to merge 1 commit into
agnesadoga-creator wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #16
Problem
Merchants who upgraded their plan kept hitting the old, lower rate limit because cached limiter state was not invalidated on upgrade.
Fix
RateLimiterServicenow caches the resolved per-tier limit alongside the usage counter, keyed by merchant id (limitCache). Previouslyreset()only cleared the request counter, so once a limit was resolved for a merchant it stayed cached forever even after a plan change.reset()now also evicts the cached tier limit, andPlanService.upgradePlan()calls it on every upgrade so the next request recomputes the limit from the merchant's new tier instead of reusing the stale one.Testing
Reviewed by inspection (no local build/test run per task scope - dependencies not installed). Existing
test/rate-limiter.spec.tsstill passes by inspection: reset() continues to zero out the usage counter.