Retry Horizon RPC calls on transient 503 responses#237
Open
agnesadoga-creator wants to merge 1 commit into
Open
Retry Horizon RPC calls on transient 503 responses#237agnesadoga-creator wants to merge 1 commit into
agnesadoga-creator wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1
Problem
Horizon RPC calls that receive a transient 503 were not retried, causing avoidable failures.
Fix
HealthService.checkHttp(used for thestellar_horizoncheck againstHORIZON_URL) now retries up to 2 additional times, with a short increasing backoff (200ms, 400ms), when Horizon responds with a transient status code (502, 503, or 504). Non-transient responses (2xx or other error codes like 500) still return immediately, matching previous behavior.Testing
Reviewed by inspection (no local build/test run per task scope — dependencies not installed).