Pulling work from scattering/width paper into main #73
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 14 commits
June 3, 2025 14:56
…cy with scattering paper
profxj
approved these changes
Sep 24, 2025
Contributor
profxj
left a comment
profxj
left a comment
There was a problem hiding this comment.
wow, great stuff!
I've left comments, suggestions and the like but am approving too
| thresh, Emin, Emax, self.state.energy.gamma, self.use_log10 | ||
| ).T * w.T).T | ||
| ) | ||
|
|
Contributor
There was a problem hiding this comment.
have you tested whether this changed code gives the same results as before (if run the same way)?
| Note that now, RA, DEC, Gl, and Gb will be present | ||
| But their default values are None | ||
| """ | ||
| # converts to float if in string. Will do nothing if None |
Contributor
There was a problem hiding this comment.
Am trying to intuit why this would be needed..
Collaborator
Author
There was a problem hiding this comment.
Basically, if people publish an FRB in RA/DEC, or in Gl Gb, but not the other. Makes it easier for entering data. You need Gl, Gb for NE2001 estimates, and to place cuts on Gl, Gb to remove fluctuations due to the Galactic Plane
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per title. This pull adds the capability to fit scattering and width distributions simultaneously with other FRB parameters. it includes work from the scattering paper.