Craco-motivated update to scattering #72
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 14 commits
May 12, 2025 09:50
… path script directory
…sing zDM and PATH
…some maximum width
…idth distribution
…Next stop - getting actual data values, and converging on them
… and made minor changes to reduce noise in the program
… minor cosmetic things
profxj
requested changes
May 24, 2025
Contributor
profxj
left a comment
profxj
left a comment
There was a problem hiding this comment.
Holy new code!
Great stuff. My main additional request is to add a few
tests related to the new width code.
added 8 commits
May 26, 2025 13:08
…ptical.py to allow separation of these modules from standard zdm functionality
JordanHoffmann3
approved these changes
May 29, 2025
Collaborator
JordanHoffmann3
left a comment
JordanHoffmann3
left a comment
There was a problem hiding this comment.
I think it makes sense to me after a lot of staring
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This update is to begin modelling CRACO.
I have added code from Andy to calculate CRACO beamshapes.
However, the ability of CRACO to probe wider FRBs - and evidence from observations - suggests the need to update scattering. We now have the ability to set intrinsic width ~ (1+z) and scattering to go as (1+z)^-3
See new plot in scripts/Scattering that shows the effect of different scattering treatments,.
I have NOT updated the default values however. Nor have I determined if the new upper-lognormal (lognormal on lower-side, log-constant on upper side) function is reasonable. Next step is to work out how to fit for this!