windhorst et al 2023 F200W mag Priors #22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
profxj
approved these changes
Feb 21, 2025
Contributor
profxj
left a comment
profxj
left a comment
There was a problem hiding this comment.
thx for this!
can you add/edit a doc too to docs/
Contributor
|
also, we need to pass tests |
Contributor
|
and it would be great if you added a test |
Fixing failing tests due to numpy
This reverts commit 17651c2.
profxj
requested changes
Apr 26, 2025
Contributor
profxj
left a comment
profxj
left a comment
There was a problem hiding this comment.
can you also add a test?
Thanks!
| logging.info("Localization is ready!") | ||
|
|
||
| def calc_priors(self): | ||
| def calc_priors(self, ifilter:str='r'): |
Contributor
There was a problem hiding this comment.
please add a doc string for ifilter
astropath/priors.py
Outdated
| help='Label for this prior.'), | ||
| } | ||
|
|
||
| splines = { |
Contributor
There was a problem hiding this comment.
add some docs describing this
Contributor
|
@lordrick94 -- did you address my comments above? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
Code to calculate Mag Priors for F200W
A notebook with descriptions and tests
Data (.npz) file with spline values