Fix RRATalog parser to account for differing observing frequencies #2
+181
−43
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also provide an example input for the RRATalog (which has not been updated since 2018 and thus should be stable for the future), and update the output rrats_nohead file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default, the RRATalog parser assumed that all values were measured at 1.4GHz, which isn't always the case. This changes the
update_rrats.cshscript to a bash script,update_rrats.shwhich correctly accounts for this, parses the current three frequency samples, and sorts them by name in the outputrrats_noheadfile.This also updates the output
rrats_noheadfile (some values may change due to updates/rounding in the current version of the RRATalog), and provides a sample input files for theupdate_rrats.shscript.Before/after plots attached.