Skip to content

Conversation

@profxj
Copy link
Contributor

@profxj profxj commented Dec 15, 2025

As titled

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@profxj profxj requested a review from krittisharma December 16, 2025 02:06
"AV_old_loerr": -0.143,
"AV_old_ref": "Sharma2024",
"AV_old_uperr": 0.1565,
"Mtotal": 4998043135.782396,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

log M* in Sharma+2024 is not the total stellar mass formed. It is corrected for the surviving mass fraction. I hope that's what Mtotal means?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah, good catch.

Is there a total mass provided in Sharma+2024?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

logMstar is the current stellar mass and logmass is the total stellar mass formed here: https://github.com/krittisharma/frb_host_sharma2024/blob/main/frbs_data/dsa_frbs.csv. I think Alexa also reports the current stellar mass in her work.

Copy link
Collaborator

@krittisharma krittisharma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

log M_total definition needs to be checked

@profxj
Copy link
Contributor Author

profxj commented Jan 1, 2026

logmass fixed

@profxj profxj reopened this Jan 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants