-
Notifications
You must be signed in to change notification settings - Fork 31
Add derived quantities from Sharma2024 #225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
| "AV_old_loerr": -0.143, | ||
| "AV_old_ref": "Sharma2024", | ||
| "AV_old_uperr": 0.1565, | ||
| "Mtotal": 4998043135.782396, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
log M* in Sharma+2024 is not the total stellar mass formed. It is corrected for the surviving mass fraction. I hope that's what Mtotal means?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah, good catch.
Is there a total mass provided in Sharma+2024?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
logMstar is the current stellar mass and logmass is the total stellar mass formed here: https://github.com/krittisharma/frb_host_sharma2024/blob/main/frbs_data/dsa_frbs.csv. I think Alexa also reports the current stellar mass in her work.
krittisharma
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
log M_total definition needs to be checked
|
logmass fixed |
As titled