Adding 2mass survey #211
Merged
Adding 2mass survey #211
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Survey hotfixes
SunilSimha
requested changes
Jul 23, 2025
Collaborator
SunilSimha
left a comment
SunilSimha
left a comment
There was a problem hiding this comment.
Thanks for this. Sorry about the delay in getting to this PR. I'll ask you to add unit tests to tests/test_surveys.py for GALEX and 2MASS. Thanks!
Collaborator
Author
|
okay it passed the tests, let me just fix the column names and add them to the list and this one should be good to go |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2mass survey added and works, and now checks for extended source catalog first before point source catalog