M31 refactor #208
Merged
M31 refactor #208
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lordrick94
requested review from
SunilSimha and
profxj
and removed request for
SunilSimha and
profxj
SunilSimha
requested changes
May 22, 2025
Collaborator
SunilSimha
left a comment
SunilSimha
left a comment
There was a problem hiding this comment.
Requesting minor edits. Thanks!
profxj
approved these changes
May 22, 2025
Contributor
profxj
left a comment
profxj
left a comment
There was a problem hiding this comment.
good stuff
do we need a new test?
SunilSimha
approved these changes
May 23, 2025
Collaborator
SunilSimha
left a comment
SunilSimha
left a comment
There was a problem hiding this comment.
Looks good now. The M31 halo unit test seems to be passing at the moment but as X said, if you think we should add an assert statement or two to test the new definitions, @lordrick94 we should.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding logMCGM input for M31 mNFW object