Skip to content

Conversation

@SunilSimha
Copy link
Collaborator

Searching cluster catalogs in Vizier.

@SunilSimha SunilSimha requested a review from aelanman April 24, 2025 22:20
@leungcalvin
Copy link
Collaborator

This is a really cool tool. Call me nosy, but I was playing with this a bit today: I guess clean_catalog is not fully mature yet, but I'm not getting any hits with a 3 degree radius? Seems weird.

import importlib
from frb.surveys import cluster_search
importlib.reload(cluster_search)
import astropy.coordinates as ac
import astropy.units as u

hg = ac.SkyCoord(ra = '01h45m52.26s', dec = '35d06m28.19s')

for survey in [cluster_search.TullyGroupCat,cluster_search.WenGroupCat,cluster_search.UPClusterSZCat,cluster_search.TempelClusterCat,cluster_search.ROSATXClusterCat]:
    a = survey(coord = hg, radius = 3 * u.deg)
    a._get_catalog()
    print(a.catalog)

image

@SunilSimha
Copy link
Collaborator Author

@leungcalvin you need to use get_catalog() instead of _get_catalog(). The latter is a helper function from the parent class.

Copy link
Collaborator

@aelanman aelanman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Sorry it took so long to get to this

@SunilSimha SunilSimha marked this pull request as ready for review December 10, 2025 14:59
@SunilSimha SunilSimha merged commit 8eac255 into main Dec 10, 2025
4 checks passed
@SunilSimha SunilSimha deleted the local_universe branch December 10, 2025 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants