KCWI datacube handling #203
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
leungcalvin
requested changes
Apr 28, 2025
Collaborator
leungcalvin
left a comment
leungcalvin
left a comment
There was a problem hiding this comment.
Mostly looks good - see my comment about DESI Y1 vs Y3
leungcalvin
reviewed
Apr 28, 2025
nanmedian as suggested.
nanmedian as suggested.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This code deals with KCWI datacubes for:
Refactored some code to make it compatible with the latest
spectral-cuberepository. Also, all relevant functions are now packaged into a convenient class that can be instantiated with data from a reduced cube from PypeIt or KCWI DRP. There's also an updated notebook to showcase the usage of this module.