Skip to content

Conversation

@astro-vic
Copy link
Collaborator

Updated TNS crossmatching script, now compatible with TNS 2.0 API querying.

Updated TNS crossmatching script, now compatible with TNS 2.0 API querying.
Copy link
Contributor

@profxj profxj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this!

docstring descriptions of variables and what the functions do
@astro-vic
Copy link
Collaborator Author

Thanks for this!

I updated the script based on your suggestions! let me know if there's anything else to add. Thanks X!

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@charliekilpatrick
Copy link
Collaborator

Updated TNS scripts test is working locally:

(alopeke) [ckilpatrick@andromeda ~/scripts/python/frb/F4/FRB]$ pytest frb/tests/test_tnsscripts.py
============================================================================= test session starts ==============================================================================
platform darwin -- Python 3.10.10, pytest-7.3.1, pluggy-1.0.0
rootdir: /Users/ckilpatrick/Dropbox/scripts/python/frb/F4/FRB
plugins: hypothesis-6.72.4, remotedata-0.4.0, asdf-2.15.0, ligo.skymap-2.3.0, anyio-4.0.0, arraydiff-0.3, mock-3.10.0, doctestplus-0.12.1, astropy-0.10.0, filter-subpackage-0.1.1, cov-4.0.0, openfiles-0.5.0, astropy-header-0.1.2
collected 1 item

frb/tests/test_tnsscripts.py .                                                                                                                                           [100%]

=============================================================================== warnings summary ===============================================================================
../../../../../../scripts/anaconda3/envs/alopeke/lib/python3.10/site-packages/asdf/schema.py:14
  /Users/ckilpatrick/scripts/anaconda3/envs/alopeke/lib/python3.10/site-packages/asdf/schema.py:14: DeprecationWarning: jsonschema.exceptions.RefResolutionError is deprecated as of version 4.18.0. If you wish to catch potential reference resolution errors, directly catch referencing.exceptions.Unresolvable.
    from jsonschema.exceptions import RefResolutionError, ValidationError

-- Docs: https://docs.pytest.org/en/stable/how-to/capture-warnings.html
========================================================================= 1 passed, 1 warning in 4.30s =========================================================================

@charliekilpatrick charliekilpatrick requested a review from profxj June 4, 2025 14:52
Copy link
Contributor

@profxj profxj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great stuff!

@profxj profxj merged commit 8881864 into main Jun 4, 2025
4 checks passed
@profxj profxj deleted the vic-dev branch June 4, 2025 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants