Skip to content

Conversation

@btravisebsco
Copy link
Contributor

Purpose

This PR begins the process of replacing the existing BatchPoster task functionality with new tasks based on the folio_data_import library, and fixes an issue with existing BatchPoster not counting records posted in batch.

Changes Made in this PR

  • Implement InventoryBatchPoster, MARCImportTask, and UserImportTask wrapper classes for the corresponding functionality in folio_data_import
  • Fix batch-posted record counting issue in existing BatchPoster task

Code Review Specifics

Task Checklist

  • Ran nox -rs safety.
  • Ran pre-commit run --all-files
  • Tests cover new or modified code.
  • Ran test suite: nox -rs tests
  • Code runs and outputs default usage info: cd src; poetry run python3 -m folio_migration_tools -h
  • Documentation updated

Warning Checklist

  • New dependencies added
  • Includes breaking changes

How to Verify

Open Questions

Learn Anything Cool?

@sonarqubecloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants