Skip to content

Conversation

@btravisebsco
Copy link
Contributor

Purpose

Fix edge case around upsert performance in some Eureka environments by adding a configurable semaphore to limit simultaneous requests.

Changes Made in this PR

Code Review Specifics

Task Checklist

  • Ran nox -rs safety.
  • Ran pre-commit run --all-files
  • Tests cover new or modified code.
  • Ran test suite: nox -rs tests
  • Code runs and outputs default usage info: cd src; poetry run python3 -m folio_migration_tools -h
  • Documentation updated

Warning Checklist

  • New dependencies added
  • Includes breaking changes

How to Verify

Open Questions

Learn Anything Cool?

@sonarqubecloud
Copy link

@codecov
Copy link

codecov bot commented Jan 27, 2026

Codecov Report

❌ Patch coverage is 85.71429% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 77.58%. Comparing base (7cb7853) to head (56d23f3).
⚠️ Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
...io_migration_tools/migration_tasks/batch_poster.py 75.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #985   +/-   ##
=======================================
  Coverage   77.58%   77.58%           
=======================================
  Files         107      107           
  Lines       14298    14304    +6     
  Branches     1759     1760    +1     
=======================================
+ Hits        11093    11098    +5     
- Misses       2868     2869    +1     
  Partials      337      337           
Flag Coverage Δ
unittests 77.58% <85.71%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@btravisebsco btravisebsco merged commit a58fdd6 into main Jan 27, 2026
5 checks passed
@btravisebsco btravisebsco deleted the fix/add-semaphore-to-batch-poster branch January 27, 2026 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants