Feature/save-raw-report-data #980
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Introduced a new directory for raw migration reports in FolderStructure. - Updated the migration report class to include a method for writing reports in JSON format. - Enhanced folder verification to create missing directories as needed. - Added tests to ensure the creation of subfolders and proper handling of missing base folders.
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #980 +/- ##
==========================================
+ Coverage 76.98% 77.20% +0.21%
==========================================
Files 104 106 +2
Lines 13955 14036 +81
Branches 1734 1736 +2
==========================================
+ Hits 10743 10836 +93
+ Misses 2867 2859 -8
+ Partials 345 341 -4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
- Introduced i18n caching with the `i18n_t` function to improve performance by caching translation results. - Updated various modules to replace direct calls to `i18n.t` with the new `i18n_t` function for consistency and efficiency. - Added tests for the i18n caching functionality to ensure correct behavior, including cache hits, misses, and parameterized translations. - Ensured that all relevant translation strings across the migration tools are now utilizing the caching mechanism.
…fix linting errors
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Add a feature to save the raw task statistics report data as JSON alongside the Markdown version of the reports. This will will allow alternative processing/presentation of that data in the future.
Refactor how i18n translations are handled to cache frequently-used translations to improve transformation performance across the board.
Update GitHub Actions to use uv.
Changes Made in this PR
Added a raw data directory to the output folder structure, added method on the migrationreport class to output the report dictionary as JSON, and add tests. Also bump package version.
Code Review Specifics
Task Checklist
nox -rs safety.pre-commit run --all-filesnox -rs testscd src; poetry run python3 -m folio_migration_tools -hWarning Checklist
How to Verify
Open Questions
Learn Anything Cool?